minidump/minidump_memory_writer.h - Issue 896663006: win: Resolve zero-length array errors on MSVC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_memory_writer.h

Issue 896663006: win: Resolve zero-length array errors on MSVC (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump-comp

Patch Set: fixes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_memory_writer.h

diff --git a/minidump/minidump_memory_writer.h b/minidump/minidump_memory_writer.h

index bcac3321299ec4d023bccea50a87c0cebcde4504..0a6a0e659335844af001e5c2437bda1fdcf0afa1 100644

--- a/minidump/minidump_memory_writer.h

+++ b/minidump/minidump_memory_writer.h

@@ -180,9 +180,9 @@ class MinidumpMemoryListWriter final : public internal::MinidumpStreamWriter {

MinidumpStreamType StreamType() const override;

private:

- MINIDUMP_MEMORY_LIST memory_list_base_;

std::vector<MinidumpMemoryWriter*> memory_writers_; // weak

PointerVector<MinidumpMemoryWriter> children_;

+ MINIDUMP_MEMORY_LIST memory_list_base_;

DISALLOW_COPY_AND_ASSIGN(MinidumpMemoryListWriter);

};

« no previous file with comments | « minidump/minidump_location_descriptor_list_writer.cc ('k') | minidump/minidump_memory_writer.cc » ('j') | no next file with comments »