Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: minidump/minidump_simple_string_dictionary_writer.cc

Issue 896663006: win: Resolve zero-length array errors on MSVC (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump-comp
Patch Set: fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_simple_string_dictionary_writer.h ('k') | minidump/minidump_string_writer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 DCHECK_EQ(state(), kStateWritable); 84 DCHECK_EQ(state(), kStateWritable);
85 85
86 // This object doesn’t directly write anything itself. Its 86 // This object doesn’t directly write anything itself. Its
87 // MinidumpSimpleStringDictionaryEntry is written by its parent as part of a 87 // MinidumpSimpleStringDictionaryEntry is written by its parent as part of a
88 // MinidumpSimpleStringDictionary, and its children are responsible for 88 // MinidumpSimpleStringDictionary, and its children are responsible for
89 // writing themselves. 89 // writing themselves.
90 return true; 90 return true;
91 } 91 }
92 92
93 MinidumpSimpleStringDictionaryWriter::MinidumpSimpleStringDictionaryWriter() 93 MinidumpSimpleStringDictionaryWriter::MinidumpSimpleStringDictionaryWriter()
94 : MinidumpWritable(), simple_string_dictionary_base_(), entries_() { 94 : MinidumpWritable(), entries_(), simple_string_dictionary_base_() {
95 } 95 }
96 96
97 MinidumpSimpleStringDictionaryWriter::~MinidumpSimpleStringDictionaryWriter() { 97 MinidumpSimpleStringDictionaryWriter::~MinidumpSimpleStringDictionaryWriter() {
98 STLDeleteContainerPairSecondPointers(entries_.begin(), entries_.end()); 98 STLDeleteContainerPairSecondPointers(entries_.begin(), entries_.end());
99 } 99 }
100 100
101 void MinidumpSimpleStringDictionaryWriter::InitializeFromMap( 101 void MinidumpSimpleStringDictionaryWriter::InitializeFromMap(
102 const std::map<std::string, std::string>& map) { 102 const std::map<std::string, std::string>& map) {
103 DCHECK_EQ(state(), kStateMutable); 103 DCHECK_EQ(state(), kStateMutable);
104 DCHECK(entries_.empty()); 104 DCHECK(entries_.empty());
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 for (const auto& key_entry : entries_) { 176 for (const auto& key_entry : entries_) {
177 iov.iov_base = key_entry.second->MinidumpSimpleStringDictionaryEntry(); 177 iov.iov_base = key_entry.second->MinidumpSimpleStringDictionaryEntry();
178 iov.iov_len = sizeof(MinidumpSimpleStringDictionaryEntry); 178 iov.iov_len = sizeof(MinidumpSimpleStringDictionaryEntry);
179 iovecs.push_back(iov); 179 iovecs.push_back(iov);
180 } 180 }
181 181
182 return file_writer->WriteIoVec(&iovecs); 182 return file_writer->WriteIoVec(&iovecs);
183 } 183 }
184 184
185 } // namespace crashpad 185 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_simple_string_dictionary_writer.h ('k') | minidump/minidump_string_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698