win: Resolve zero-length array errors on MSVC

minidump/minidump_extensions.h

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #ifndef CRASHPAD_MINIDUMP_MINIDUMP_EXTENSIONS_H_
 #define CRASHPAD_MINIDUMP_MINIDUMP_EXTENSIONS_H_
 
 #include <windows.h>
 #include <dbghelp.h>
 #include <stdint.h>
 #include <winnt.h>
 
 #include "base/compiler_specific.h"
 #include "build/build_config.h"
 #include "util/misc/uuid.h"
 
 #if defined(COMPILER_MSVC)
+// C4200 is "nonstandard extension used : zero-sized array in struct/union".
+// We would like to globally disable this warning, but unfortunately, the
+// compiler is buggy and only supports disabling it with a pragma, so we can't
+// disable it with other silly warnings in build/common.gypi. See:
+//   https://connect.microsoft.com/VisualStudio/feedback/details/1114440
+#pragma warning(disable: 4200)

[Mark Mentovai, 2015/02/04 21:25:15]

Can we undisable it at the end of this header and still get the desired effect?
I’d rather do that if possible, so that each header that needs this #pragma is
forced to provide it on its own, rather than relying on #include order quirks.

[scottmg, 2015/02/05 01:33:26]

Done.

+#endif  // COMPILER_MSVC
+
+#if defined(COMPILER_MSVC)
 #define PACKED
 #pragma pack(push, 1)
 #else
 #define PACKED __attribute__((packed))
 #endif  // COMPILER_MSVC
 
 namespace crashpad {
 
 //! \brief Minidump stream type values for MINIDUMP_DIRECTORY::StreamType. Each
 //!     stream structure has a corresponding stream type value to identify it.
@@ skipping 418 matching lines @@
 };
 
 #if defined(COMPILER_MSVC)
 #pragma pack(pop)
 #endif  // COMPILER_MSVC
 #undef PACKED
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_MINIDUMP_MINIDUMP_EXTENSIONS_H_