Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: minidump/minidump_thread_writer.cc

Issue 896663006: win: Resolve zero-length array errors on MSVC (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump-comp
Patch Set: fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_thread_writer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 DCHECK_EQ(state(), kStateWritable); 122 DCHECK_EQ(state(), kStateWritable);
123 123
124 // This object doesn’t directly write anything itself. Its MINIDUMP_THREAD is 124 // This object doesn’t directly write anything itself. Its MINIDUMP_THREAD is
125 // written by its parent as part of a MINIDUMP_THREAD_LIST, and its children 125 // written by its parent as part of a MINIDUMP_THREAD_LIST, and its children
126 // are responsible for writing themselves. 126 // are responsible for writing themselves.
127 return true; 127 return true;
128 } 128 }
129 129
130 MinidumpThreadListWriter::MinidumpThreadListWriter() 130 MinidumpThreadListWriter::MinidumpThreadListWriter()
131 : MinidumpStreamWriter(), 131 : MinidumpStreamWriter(),
132 thread_list_base_(),
133 threads_(), 132 threads_(),
134 memory_list_writer_(nullptr) { 133 memory_list_writer_(nullptr),
134 thread_list_base_() {
135 } 135 }
136 136
137 MinidumpThreadListWriter::~MinidumpThreadListWriter() { 137 MinidumpThreadListWriter::~MinidumpThreadListWriter() {
138 } 138 }
139 139
140 void MinidumpThreadListWriter::InitializeFromSnapshot( 140 void MinidumpThreadListWriter::InitializeFromSnapshot(
141 const std::vector<const ThreadSnapshot*>& thread_snapshots, 141 const std::vector<const ThreadSnapshot*>& thread_snapshots,
142 MinidumpThreadIDMap* thread_id_map) { 142 MinidumpThreadIDMap* thread_id_map) {
143 DCHECK_EQ(state(), kStateMutable); 143 DCHECK_EQ(state(), kStateMutable);
144 DCHECK(threads_.empty()); 144 DCHECK(threads_.empty());
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 } 222 }
223 223
224 return file_writer->WriteIoVec(&iovecs); 224 return file_writer->WriteIoVec(&iovecs);
225 } 225 }
226 226
227 MinidumpStreamType MinidumpThreadListWriter::StreamType() const { 227 MinidumpStreamType MinidumpThreadListWriter::StreamType() const {
228 return kMinidumpStreamTypeThreadList; 228 return kMinidumpStreamTypeThreadList;
229 } 229 }
230 230
231 } // namespace crashpad 231 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_thread_writer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698