Add targets for generating version files in Windows GN build.

Add targets for generating version files in Windows GN build.

Now chrome_version.cc  and version .rc files are generated.

Committed: https://crrev.com/319ba630ef61fe8d70f553b4925870960317b660
Cr-Commit-Position: refs/heads/master@{#313798}

[Slava Chigrin, 2015-01-26 20:40:48]

vchigrin@yandex-team.ru changed reviewers:
+ dpranke@chromium.org, thestig@chromium.org

[Slava Chigrin, 2015-01-26 23:29:09]

https://codereview.chromium.org/874413003/diff/1/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/874413003/diff/1/chrome/common/BUILD.gn#newco...
chrome/common/BUILD.gn:297: "-t @MAJOR@.@MINOR@.@BUILD@.@PATCH@",
See
https://code.google.com/p/chromium/codesearch#chromium/src/build/util/version...

https://codereview.chromium.org/874413003/diff/1/chrome/common/BUILD.gn#newco...
chrome/common/BUILD.gn:303: "$version_full",
See
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common_cons...

[Lei Zhang, 2015-01-27 00:56:10]

thestig@chromium.org changed reviewers:
+ brettw@chromium.org

[Lei Zhang, 2015-01-27 00:56:10]

brettw is probably a better reviewer. I can (slowly) take a look if he doesn't
have enough bandwidth.

[brettw, 2015-01-27 23:58:07]

https://codereview.chromium.org/874413003/diff/1/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/874413003/diff/1/chrome/common/BUILD.gn#newco...
chrome/common/BUILD.gn:293: version_full =
exec_script("//build/util/version.py",
I think we should be able to work around doing this. Doing all of these scripts
every time GN runs really sucks, since this is really a build step.

The GYP build really likes to do these script calls and I was always able to
work around it. If you look at chrome/version.gni you can see chrome/VERSION
being passed as an arg to the script with the -f flag, which I think will have
the same effect as running the script and passing the result on the command
line.

[Slava Chigrin, 2015-01-28 14:48:31]

Patchset #3 (id:40001) has been deleted

[Slava Chigrin, 2015-01-28 14:48:38]

Patchset #3 (id:60001) has been deleted

[Slava Chigrin, 2015-01-28 17:29:14]

Patchset #4 (id:100001) has been deleted

[Slava Chigrin, 2015-01-28 17:34:51]

Thank you for review,
unfortunately, make_version_cc.py is very simple script, that can not take file
in it arguments. So, I decided to replace its invokation by process_version()
with custom template (in fact this is the first approach that I tried locally
due to it simplicity, but then rejected in favour of copying GYP behavior).

Hope, that approach is acceptable.

[brettw, 2015-01-28 21:06:45]

I see, I didn't notice the script was different. The new approach looks great.

Can we fix the GYP build? I'm concerned that they may get out-of-sync,
especially since people often forget to update the GN build.

I think this should be a pretty straightforward copy-and-paste job to make GYP
work. For example, you can start with 'chrome_version' in chrome_common.gypi,
remove the conditions and most of the params/inputs, and get exactly what the GN
one is doing. Then we can delete make_version_cc.py (looks like this is the only
user).

Thanks for putting up with this, I think it will be a nice improvement.

https://codereview.chromium.org/874413003/diff/120001/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/874413003/diff/120001/chrome/common/BUILD.gn#...
chrome/common/BUILD.gn:269: "$target_gen_dir/chrome_version.cc",
A slightly more robust way of doing this is to move the process_version call
above this target, and do:
    ...(sources)...
  ] + get_target_outputs(":make_chrome_version")

https://codereview.chromium.org/874413003/diff/120001/chrome/common/chrome_ve...
File chrome/common/chrome_version.cc.version (right):

https://codereview.chromium.org/874413003/diff/120001/chrome/common/chrome_ve...
chrome/common/chrome_version.cc.version:1: #include
"chrome/common/chrome_constants.h"
You should probably add the copyright here like normal files.

[Slava Chigrin, 2015-01-29 13:13:22]

Thank you for review, uploaded new version. Launched clobbered try job
(win8_chromium_rel) to test GYP, and it succeed.

https://codereview.chromium.org/874413003/diff/120001/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/874413003/diff/120001/chrome/common/BUILD.gn#...
chrome/common/BUILD.gn:269: "$target_gen_dir/chrome_version.cc",
Done. Added that as separate line since in other case gn format re-formats all
sources[] list in a bit weird way.

https://codereview.chromium.org/874413003/diff/120001/chrome/common/chrome_ve...
File chrome/common/chrome_version.cc.version (right):

https://codereview.chromium.org/874413003/diff/120001/chrome/common/chrome_ve...
chrome/common/chrome_version.cc.version:1: #include
"chrome/common/chrome_constants.h"
On 2015/01/28 21:06:45, brettw wrote:
> You should probably add the copyright here like normal files.

Done.

[brettw, 2015-01-29 20:44:19]

lgtm

[Slava Chigrin, 2015-01-29 20:44:46]

The CQ bit was checked by vchigrin@yandex-team.ru

[commit-bot: I haz the power, 2015-01-29 20:45:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874413003/140001

[commit-bot: I haz the power, 2015-01-29 21:41:06]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2015-01-29 21:42:42]

Patchset 5 (id:??) landed as
https://crrev.com/319ba630ef61fe8d70f553b4925870960317b660
Cr-Commit-Position: refs/heads/master@{#313798}