chrome/common/chrome_version.cc.version - Issue 874413003: Add targets for generating version files in Windows GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_version.cc.version

Issue 874413003: Add targets for generating version files in Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issues after review, update GYP. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/chrome_version.cc.version

diff --git a/build/android/pylib/remote/device/dummy/src/org/chromium/dummy/Dummy.java b/chrome/common/chrome_version.cc.version

similarity index 52%

copy from build/android/pylib/remote/device/dummy/src/org/chromium/dummy/Dummy.java

copy to chrome/common/chrome_version.cc.version

index 1281b39586e399c3103b5f2ab3ca1f3fab26d182..54e062bb931046619a1e1a53298d2cbccbecccad 100644

--- a/build/android/pylib/remote/device/dummy/src/org/chromium/dummy/Dummy.java

+++ b/chrome/common/chrome_version.cc.version

@@ -2,8 +2,10 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-package org.chromium.dummy;

+#include "chrome/common/chrome_constants.h"

-/** Does nothing. */

-class Dummy {}

+namespace chrome {

+const char kChromeVersion[] = "@MAJOR@.@MINOR@.@BUILD@.@PATCH@";

+} // namespace chrome

« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/common_constants.gyp » ('j') | no next file with comments »