Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: chrome/common/BUILD.gn

Issue 874413003: Add targets for generating version files in Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix issues after review, update GYP. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/common/chrome_version.cc.version » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//tools/grit/grit_rule.gni") 5 import("//tools/grit/grit_rule.gni")
6 6
7 gypi_values = exec_script("//build/gypi_to_gn.py", 7 gypi_values = exec_script("//build/gypi_to_gn.py",
8 [ rebase_path("../chrome_common.gypi") ], 8 [ rebase_path("../chrome_common.gypi") ],
9 "scope", 9 "scope",
10 [ "../chrome_common.gypi" ]) 10 [ "../chrome_common.gypi" ])
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 } 233 }
234 } 234 }
235 235
236 import("//chrome/version.gni") 236 import("//chrome/version.gni")
237 process_version("version") { 237 process_version("version") {
238 visibility = [ ":common" ] 238 visibility = [ ":common" ]
239 source = "chrome_version_info_values.h.version" 239 source = "chrome_version_info_values.h.version"
240 output = "$target_gen_dir/chrome_version_info_values.h" 240 output = "$target_gen_dir/chrome_version_info_values.h"
241 } 241 }
242 242
243 process_version("make_chrome_version") {
244 source = "chrome_version.cc.version"
245 output = "$target_gen_dir/chrome_version.cc"
246 }
247
243 # GN version: chrome/common_constants.gyp:common_constants 248 # GN version: chrome/common_constants.gyp:common_constants
244 static_library("constants") { 249 static_library("constants") {
245 sources = [ 250 sources = [
246 "chrome_constants.cc", 251 "chrome_constants.cc",
247 "chrome_constants.h", 252 "chrome_constants.h",
248 "chrome_icon_resources_win.cc", 253 "chrome_icon_resources_win.cc",
249 "chrome_icon_resources_win.h", 254 "chrome_icon_resources_win.h",
250 "chrome_paths.cc", 255 "chrome_paths.cc",
251 "chrome_paths.h", 256 "chrome_paths.h",
252 "chrome_paths_android.cc", 257 "chrome_paths_android.cc",
253 "chrome_paths_internal.h", 258 "chrome_paths_internal.h",
254 "chrome_paths_linux.cc", 259 "chrome_paths_linux.cc",
255 "chrome_paths_mac.mm", 260 "chrome_paths_mac.mm",
256 "chrome_paths_win.cc", 261 "chrome_paths_win.cc",
257 "chrome_switches.cc", 262 "chrome_switches.cc",
258 "chrome_switches.h", 263 "chrome_switches.h",
259 "env_vars.cc", 264 "env_vars.cc",
260 "env_vars.h", 265 "env_vars.h",
261 "net/test_server_locations.cc", 266 "net/test_server_locations.cc",
262 "net/test_server_locations.h", 267 "net/test_server_locations.h",
263 "pref_font_script_names-inl.h", 268 "pref_font_script_names-inl.h",
264 "pref_font_webkit_names.h", 269 "pref_font_webkit_names.h",
265 "pref_names.cc", 270 "pref_names.cc",
266 "pref_names.h", 271 "pref_names.h",
267 "widevine_cdm_constants.cc", 272 "widevine_cdm_constants.cc",
268 "widevine_cdm_constants.h", 273 "widevine_cdm_constants.h",
269 ] 274 ]
275 sources += get_target_outputs(":make_chrome_version")
270 276
271 deps = [ 277 deps = [
278 ":make_chrome_version",
272 "//base", 279 "//base",
273 "//base/third_party/dynamic_annotations", 280 "//base/third_party/dynamic_annotations",
274 "//components/bookmarks/common", 281 "//components/bookmarks/common",
275 "//third_party/widevine/cdm:version_h", 282 "//third_party/widevine/cdm:version_h",
276 ] 283 ]
277 284
278 if (enable_nacl) { 285 if (enable_nacl) {
279 deps += [ 286 deps += [
280 #'../components/nacl.gyp:nacl_switches', TODO(GYP) 287 #'../components/nacl.gyp:nacl_switches', TODO(GYP)
281 ] 288 ]
(...skipping 21 matching lines...) Expand all
303 ] 310 ]
304 } 311 }
305 312
306 if (enable_extensions) { 313 if (enable_extensions) {
307 sources += [ 314 sources += [
308 "extensions/extension_test_util.cc", 315 "extensions/extension_test_util.cc",
309 "extensions/extension_test_util.h", 316 "extensions/extension_test_util.h",
310 ] 317 ]
311 } 318 }
312 } 319 }
OLDNEW
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/common/chrome_version.cc.version » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698