chrome/common_constants.gyp - Issue 874413003: Add targets for generating version files in Windows GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common_constants.gyp

Issue 874413003: Add targets for generating version files in Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issues after review, update GYP. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common_constants.gyp

diff --git a/chrome/common_constants.gyp b/chrome/common_constants.gyp

index 9725cada7c488d8503667ab1520fc427b965ebf1..45c04cdfb725feceae0d45cb3a86198682d07b9d 100644

--- a/chrome/common_constants.gyp

+++ b/chrome/common_constants.gyp

@@ -41,20 +41,25 @@

{

'action_name': 'Make chrome_version.cc',

'variables': {

- 'make_version_cc_path': 'tools/build/make_version_cc.py',

+ 'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE',

+ 'template_input_path': 'common/chrome_version.cc.version',

'inputs': [

- '<(make_version_cc_path)',

- 'VERSION',

+ '<(version_py_path)',

+ '<(version_path)',

+ '<(lastchange_path)',

+ '<(template_input_path)',

'outputs': [

'<(INTERMEDIATE_DIR)/chrome_version.cc',

'action': [

'python',

- '<(make_version_cc_path)',

+ '<(version_py_path)',

+ '-f', '<(version_path)',

+ '-f', '<(lastchange_path)',

+ '<(template_input_path)',

'<@(_outputs)',

- '<(version_full)',

'process_outputs_as_sources': 1,

« no previous file with comments | « chrome/common/chrome_version.cc.version ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »