Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: chrome/BUILD.gn

Issue 874413003: Add targets for generating version files in Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix issues after review, update GYP. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/common/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/locales.gni") 6 import("//build/config/locales.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//chrome/chrome_repack_locales.gni") 8 import("//chrome/chrome_repack_locales.gni")
9 import("//chrome/version.gni") 9 import("//chrome/version.gni")
10 10
(...skipping 13 matching lines...) Expand all
24 ] 24 ]
25 deps = [] 25 deps = []
26 datadeps = [] 26 datadeps = []
27 27
28 # TODO(GYP) mac_bundle_resources, xcode_settings 28 # TODO(GYP) mac_bundle_resources, xcode_settings
29 29
30 # TODO(GYP) order_profiling, order_text_section 30 # TODO(GYP) order_profiling, order_text_section
31 31
32 if (is_win) { 32 if (is_win) {
33 sources += [ 33 sources += [
34 "$target_gen_dir/chrome_exe_version.rc",
34 "app/chrome_exe_main_win.cc", 35 "app/chrome_exe_main_win.cc",
35 "app/client_util.cc", 36 "app/client_util.cc",
36 "app/client_util.h", 37 "app/client_util.h",
37 "app/signature_validator_win.cc", 38 "app/signature_validator_win.cc",
38 "app/signature_validator_win.h", 39 "app/signature_validator_win.h",
39 "//content/app/startup_helper_win.cc", 40 "//content/app/startup_helper_win.cc",
40 ] 41 ]
41 deps += [ 42 deps += [
43 ":chrome_version_resources",
42 ":image_pre_reader", 44 ":image_pre_reader",
43 "//chrome/browser:chrome_process_finder", 45 "//chrome/browser:chrome_process_finder",
44 "//chrome/chrome_watcher", 46 "//chrome/chrome_watcher",
45 "//chrome/chrome_watcher:client", 47 "//chrome/chrome_watcher:client",
46 "//components/browser_watcher:browser_watcher_client", 48 "//components/browser_watcher:browser_watcher_client",
47 "//ui/gfx", 49 "//ui/gfx",
48 ] 50 ]
49 } else if (use_aura) { 51 } else if (use_aura) {
50 # Non-Windows aura entrypoint. 52 # Non-Windows aura entrypoint.
51 sources += [ "app/chrome_exe_main_aura.cc" ] 53 sources += [ "app/chrome_exe_main_aura.cc" ]
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 "app/close_handle_hook_win.cc", 141 "app/close_handle_hook_win.cc",
140 "app/close_handle_hook_win.h", 142 "app/close_handle_hook_win.h",
141 "app/delay_load_hook_win.cc", 143 "app/delay_load_hook_win.cc",
142 "app/delay_load_hook_win.h", 144 "app/delay_load_hook_win.h",
143 "//base/win/dllmain.cc", 145 "//base/win/dllmain.cc",
144 ] 146 ]
145 147
146 deps += [ 148 deps += [
147 # On Windows, link the dependencies (libraries) that make up actual 149 # On Windows, link the dependencies (libraries) that make up actual
148 # Chromium functionality into this .dll. 150 # Chromium functionality into this .dll.
149 #'chrome_version_resources', TODO(GYP) 151 ":chrome_version_resources",
150 "//chrome/app/theme:chrome_unscaled_resources", 152 "//chrome/app/theme:chrome_unscaled_resources",
151 "//chrome_elf", 153 "//chrome_elf",
152 "//content/app/resources", 154 "//content/app/resources",
153 "//crypto", 155 "//crypto",
154 "//net:net_resources", 156 "//net:net_resources",
155 "//third_party/wtl", 157 "//third_party/wtl",
156 "//ui/views", 158 "//ui/views",
157 ] 159 ]
158 if (enable_configuration_policy) { 160 if (enable_configuration_policy) {
159 deps += [ "//components/policy" ] 161 deps += [ "//components/policy" ]
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 # TODO(brettW) this should have more reduced visibility, but chrome/browser 255 # TODO(brettW) this should have more reduced visibility, but chrome/browser
254 # currently depends on this. 256 # currently depends on this.
255 #visibility = [ ":*" ] 257 #visibility = [ ":*" ]
256 source = "version.h.in" 258 source = "version.h.in"
257 259
258 # TODO(brettw) this should move to $target_gen_dir/version.h and 260 # TODO(brettw) this should move to $target_gen_dir/version.h and
259 # source files including it should reference it via "chrome/version.h" 261 # source files including it should reference it via "chrome/version.h"
260 output = "$root_gen_dir/version.h" 262 output = "$root_gen_dir/version.h"
261 } 263 }
262 264
265 process_version("chrome_exe_version") {
266 source = "//chrome/app/chrome_version.rc.version"
267 output = "$target_gen_dir/chrome_exe_version.rc"
268 extra_args = [
269 "-f",
270 rebase_path("app/chrome_exe.ver", root_build_dir),
271 ]
272 }
273
274 process_version("chrome_dll_version") {
275 source = "//chrome/app/chrome_version.rc.version"
276 output = "$target_gen_dir/chrome_dll_version.rc"
277 extra_args = [
278 "-f",
279 rebase_path("app/chrome_dll.ver", root_build_dir),
280 ]
281 }
282
283 process_version("nacl64_exe_version") {
284 source = "//chrome/app/chrome_version.rc.version"
285 output = "$target_gen_dir/nacl64_exe_version.rc"
286 extra_args = [
287 "-f",
288 rebase_path("app/nacl64_exe.ver", root_build_dir),
289 ]
290 }
291
292 process_version("other_version") {
293 source = "//chrome/app/chrome_version.rc.version"
294 output = "$target_gen_dir/other_version.rc"
295 extra_args = [
296 "-f",
297 rebase_path("app/other.ver", root_build_dir),
298 ]
299 }
300
301 group("chrome_version_resources") {
302 deps = [
303 ":chrome_exe_version",
304 ":chrome_dll_version",
305 ":nacl64_exe_version",
306 ":other_version",
307 ]
308 }
309
263 source_set("image_pre_reader") { 310 source_set("image_pre_reader") {
264 sources = [ 311 sources = [
265 "app/image_pre_reader_win.cc", 312 "app/image_pre_reader_win.cc",
266 "app/image_pre_reader_win.h", 313 "app/image_pre_reader_win.h",
267 ] 314 ]
268 deps = [ 315 deps = [
269 "//base", 316 "//base",
270 ] 317 ]
271 } 318 }
272 } 319 }
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
599 "//chrome/browser", 646 "//chrome/browser",
600 "//chrome/browser/ui", 647 "//chrome/browser/ui",
601 "//chrome/plugin", 648 "//chrome/plugin",
602 "//chrome/renderer", 649 "//chrome/renderer",
603 "//chrome/utility", 650 "//chrome/utility",
604 "//components/enhanced_bookmarks", 651 "//components/enhanced_bookmarks",
605 "//content/public/app:browser", 652 "//content/public/app:browser",
606 ] 653 ]
607 } 654 }
608 } 655 }
OLDNEW
« no previous file with comments | « no previous file | chrome/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698