Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7666)

Unified Diff: chrome/common/BUILD.gn

Issue 874413003: Add targets for generating version files in Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix issues after review, update GYP. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/common/chrome_version.cc.version » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index d6a03e0fc327ee420e593cd2d16d697999e63115..4df0efbb17f52c1fdb68fc22e55fdecee6a39d67 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -240,6 +240,11 @@ process_version("version") {
output = "$target_gen_dir/chrome_version_info_values.h"
}
+process_version("make_chrome_version") {
+ source = "chrome_version.cc.version"
+ output = "$target_gen_dir/chrome_version.cc"
+}
+
# GN version: chrome/common_constants.gyp:common_constants
static_library("constants") {
sources = [
@@ -267,8 +272,10 @@ static_library("constants") {
"widevine_cdm_constants.cc",
"widevine_cdm_constants.h",
]
+ sources += get_target_outputs(":make_chrome_version")
deps = [
+ ":make_chrome_version",
"//base",
"//base/third_party/dynamic_annotations",
"//components/bookmarks/common",
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/common/chrome_version.cc.version » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698