Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: chrome/common/BUILD.gn

Issue 874413003: Add targets for generating version files in Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//tools/grit/grit_rule.gni") 5 import("//tools/grit/grit_rule.gni")
6 6
7 gypi_values = exec_script("//build/gypi_to_gn.py", 7 gypi_values = exec_script("//build/gypi_to_gn.py",
8 [ rebase_path("../chrome_common.gypi") ], 8 [ rebase_path("../chrome_common.gypi") ],
9 "scope", 9 "scope",
10 [ "../chrome_common.gypi" ]) 10 [ "../chrome_common.gypi" ])
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 "env_vars.cc", 259 "env_vars.cc",
260 "env_vars.h", 260 "env_vars.h",
261 "net/test_server_locations.cc", 261 "net/test_server_locations.cc",
262 "net/test_server_locations.h", 262 "net/test_server_locations.h",
263 "pref_font_script_names-inl.h", 263 "pref_font_script_names-inl.h",
264 "pref_font_webkit_names.h", 264 "pref_font_webkit_names.h",
265 "pref_names.cc", 265 "pref_names.cc",
266 "pref_names.h", 266 "pref_names.h",
267 "widevine_cdm_constants.cc", 267 "widevine_cdm_constants.cc",
268 "widevine_cdm_constants.h", 268 "widevine_cdm_constants.h",
269 "$target_gen_dir/chrome_version.cc",
269 ] 270 ]
270 271
271 deps = [ 272 deps = [
273 ":make_chrome_version",
272 "//base", 274 "//base",
273 "//base/third_party/dynamic_annotations", 275 "//base/third_party/dynamic_annotations",
274 "//components/bookmarks/common", 276 "//components/bookmarks/common",
275 "//third_party/widevine/cdm:version_h", 277 "//third_party/widevine/cdm:version_h",
276 ] 278 ]
277 279
278 if (enable_nacl) { 280 if (enable_nacl) {
279 deps += [ 281 deps += [
280 #'../components/nacl.gyp:nacl_switches', TODO(GYP) 282 #'../components/nacl.gyp:nacl_switches', TODO(GYP)
281 ] 283 ]
282 } 284 }
283 } 285 }
284 286
287 action("make_chrome_version") {
288 script = "//chrome/tools/build/make_version_cc.py"
289 outputs = [
290 "$target_gen_dir/chrome_version.cc",
291 ]
292
293 version_full = exec_script("//build/util/version.py",
brettw 2015/01/27 23:58:07 I think we should be able to work around doing thi
294 [
295 "-f",
296 rebase_path("//chrome/VERSION", root_build_dir),
297 "-t @MAJOR@.@MINOR@.@BUILD@.@PATCH@",
Slava Chigrin 2015/01/26 23:29:09 See https://code.google.com/p/chromium/codesearch#
298 ],
299 "trim string",
300 [ "//chrome/VERSION" ])
301 args = [
302 rebase_path("$target_gen_dir/chrome_version.cc", root_build_dir),
303 "$version_full",
Slava Chigrin 2015/01/26 23:29:09 See https://code.google.com/p/chromium/codesearch#
304 ]
305 }
306
285 source_set("test_support") { 307 source_set("test_support") {
286 testonly = true 308 testonly = true
287 visibility = [ "//chrome/test:test_support" ] 309 visibility = [ "//chrome/test:test_support" ]
288 310
289 sources = [] 311 sources = []
290 312
291 deps = [ 313 deps = [
292 ":common", 314 ":common",
293 "//base", 315 "//base",
294 "//testing/gtest", 316 "//testing/gtest",
295 ] 317 ]
296 318
297 if (is_win || is_mac) { 319 if (is_win || is_mac) {
298 sources += [ 320 sources += [
299 "media_galleries/picasa_test_util.cc", 321 "media_galleries/picasa_test_util.cc",
300 "media_galleries/picasa_test_util.h", 322 "media_galleries/picasa_test_util.h",
301 "media_galleries/pmp_test_util.cc", 323 "media_galleries/pmp_test_util.cc",
302 "media_galleries/pmp_test_util.h", 324 "media_galleries/pmp_test_util.h",
303 ] 325 ]
304 } 326 }
305 327
306 if (enable_extensions) { 328 if (enable_extensions) {
307 sources += [ 329 sources += [
308 "extensions/extension_test_util.cc", 330 "extensions/extension_test_util.cc",
309 "extensions/extension_test_util.h", 331 "extensions/extension_test_util.h",
310 ] 332 ]
311 } 333 }
312 } 334 }
OLDNEW
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698