Use ShellPtr type in ApplicationLoader instead of untyped handles

Use ShellPtr type in ApplicationLoader instead of untyped handles

This clarifies what the handle is actually supposed to refer to and
will make it easier to do the Shell/Application client split correctly.

R=davemoore@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/fcb2783cd00d2313a1338d7e45b0d1788670dd4a

[jamesr, 2015-01-23 00:51:16]

jamesr@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[DaveMoore, 2015-01-23 18:55:34]

davemoore@chromium.org changed reviewers:
+ davemoore@chromium.org

[DaveMoore, 2015-01-23 18:55:34]

https://codereview.chromium.org/873453004/diff/1/mojo/public/cpp/application/...
File mojo/public/cpp/application/application_impl.h (right):

https://codereview.chromium.org/873453004/diff/1/mojo/public/cpp/application/...
mojo/public/cpp/application/application_impl.h:58: // to construct an
ApplicationImpl with is a ShellPtr.
These methods are left over from when every application got passed a MojoHandle
and had to create an ApplicationImpl out of it. I didn't want every single app
to have to massage it from the MojoHandle into the ShellPtr. But now that we
have the ..Runners, I don't think they're necessary.

[jamesr, 2015-01-23 18:57:42]

On 2015/01/23 18:55:34, DaveMoore wrote:
>
https://codereview.chromium.org/873453004/diff/1/mojo/public/cpp/application/...
> File mojo/public/cpp/application/application_impl.h (right):
> 
>
https://codereview.chromium.org/873453004/diff/1/mojo/public/cpp/application/...
> mojo/public/cpp/application/application_impl.h:58: // to construct an
> ApplicationImpl with is a ShellPtr.
> These methods are left over from when every application got passed a
MojoHandle
> and had to create an ApplicationImpl out of it. I didn't want every single app
> to have to massage it from the MojoHandle into the ShellPtr. But now that we
> have the ..Runners, I don't think they're necessary.

Yeah, we have 2 copies of the massaging (in the two runners) but that's not too
bad.

[DaveMoore, 2015-01-23 19:03:28]

lgtm

[jamesr, 2015-01-23 20:43:58]

On 2015/01/23 19:03:28, DaveMoore wrote:
> lgtm

Thanks!

[jamesr, 2015-01-23 20:44:20]

Committed patchset #2 (id:20001) manually as
fcb2783cd00d2313a1338d7e45b0d1788670dd4a (presubmit successful).