Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: shell/android/background_application_loader_unittest.cc

Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/android/background_application_loader.cc ('k') | shell/android/native_viewport_application_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/android/background_application_loader_unittest.cc
diff --git a/shell/android/background_application_loader_unittest.cc b/shell/android/background_application_loader_unittest.cc
index 09bc2c8c46e737f5f036a392233ce5c98ecb3129..176cdded1578d01f33c50973a6b574393d422b82 100644
--- a/shell/android/background_application_loader_unittest.cc
+++ b/shell/android/background_application_loader_unittest.cc
@@ -18,7 +18,7 @@ class DummyLoader : public ApplicationLoader {
// ApplicationLoader overrides:
void Load(ApplicationManager* manager,
const GURL& url,
- ScopedMessagePipeHandle shell_handle,
+ ShellPtr shell,
LoadCallback callback) override {
if (simulate_app_quit_)
base::MessageLoop::current()->Quit();
@@ -48,8 +48,9 @@ TEST(BackgroundApplicationLoaderTest, Load) {
scoped_ptr<ApplicationLoader> real_loader(new DummyLoader());
BackgroundApplicationLoader loader(real_loader.Pass(), "test",
base::MessageLoop::TYPE_DEFAULT);
- MessagePipe dummy;
- loader.Load(NULL, GURL(), dummy.handle0.Pass(),
+ ShellPtr shell;
+ auto dummy = GetProxy(&shell);
+ loader.Load(NULL, GURL(), shell.Pass(),
ApplicationLoader::SimpleLoadCallback());
}
« no previous file with comments | « shell/android/background_application_loader.cc ('k') | shell/android/native_viewport_application_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698