Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1720)

Unified Diff: shell/android/ui_application_loader_android.cc

Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/android/ui_application_loader_android.h ('k') | shell/application_manager/application_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/android/ui_application_loader_android.cc
diff --git a/shell/android/ui_application_loader_android.cc b/shell/android/ui_application_loader_android.cc
index dca237c06ed57c323dd2fa58cee58d4c4840da6b..050b5cc44d987c8cc7e5c46cb4b318971f021da6 100644
--- a/shell/android/ui_application_loader_android.cc
+++ b/shell/android/ui_application_loader_android.cc
@@ -24,13 +24,13 @@ UIApplicationLoader::~UIApplicationLoader() {
void UIApplicationLoader::Load(ApplicationManager* manager,
const GURL& url,
- ScopedMessagePipeHandle shell_handle,
+ ShellPtr shell,
LoadCallback callback) {
- DCHECK(shell_handle.is_valid());
+ DCHECK(shell);
ui_message_loop_->PostTask(
FROM_HERE,
base::Bind(&UIApplicationLoader::LoadOnUIThread, base::Unretained(this),
- manager, url, base::Passed(&shell_handle)));
+ manager, url, base::Passed(&shell)));
}
void UIApplicationLoader::OnApplicationError(ApplicationManager* manager,
@@ -42,8 +42,8 @@ void UIApplicationLoader::OnApplicationError(ApplicationManager* manager,
void UIApplicationLoader::LoadOnUIThread(ApplicationManager* manager,
const GURL& url,
- ScopedMessagePipeHandle shell_handle) {
- loader_->Load(manager, url, shell_handle.Pass(), SimpleLoadCallback());
+ ShellPtr shell) {
+ loader_->Load(manager, url, shell.Pass(), SimpleLoadCallback());
}
void UIApplicationLoader::OnApplicationErrorOnUIThread(
« no previous file with comments | « shell/android/ui_application_loader_android.h ('k') | shell/application_manager/application_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698