Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: shell/android/android_handler_loader.cc

Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/android/android_handler_loader.h ('k') | shell/android/background_application_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/android/android_handler_loader.cc
diff --git a/shell/android/android_handler_loader.cc b/shell/android/android_handler_loader.cc
index a6eab42d3d99171bc9e163554e6f824f6dd95558..61b8e91cde3a90ad2fe346c5f5ae635d94b03a8f 100644
--- a/shell/android/android_handler_loader.cc
+++ b/shell/android/android_handler_loader.cc
@@ -15,11 +15,10 @@ AndroidHandlerLoader::~AndroidHandlerLoader() {
void AndroidHandlerLoader::Load(ApplicationManager* manager,
const GURL& url,
- ScopedMessagePipeHandle shell_handle,
+ ShellPtr shell,
LoadCallback callback) {
- DCHECK(shell_handle.is_valid());
- application_.reset(
- new ApplicationImpl(&android_handler_, shell_handle.Pass()));
+ DCHECK(shell);
+ application_.reset(new ApplicationImpl(&android_handler_, shell.Pass()));
}
void AndroidHandlerLoader::OnApplicationError(ApplicationManager* manager,
« no previous file with comments | « shell/android/android_handler_loader.h ('k') | shell/android/background_application_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698