Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Side by Side Diff: shell/external_application_listener_unittest.cc

Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « shell/dynamic_application_loader_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_path.h" 5 #include "base/files/file_path.h"
6 #include "base/files/file_util.h" 6 #include "base/files/file_util.h"
7 #include "base/files/scoped_temp_dir.h" 7 #include "base/files/scoped_temp_dir.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/threading/thread.h" 10 #include "base/threading/thread.h"
(...skipping 15 matching lines...) Expand all
26 namespace mojo { 26 namespace mojo {
27 namespace shell { 27 namespace shell {
28 28
29 class NotAnApplicationLoader : public ApplicationLoader { 29 class NotAnApplicationLoader : public ApplicationLoader {
30 public: 30 public:
31 NotAnApplicationLoader() {} 31 NotAnApplicationLoader() {}
32 ~NotAnApplicationLoader() override {} 32 ~NotAnApplicationLoader() override {}
33 33
34 void Load(ApplicationManager* application_manager, 34 void Load(ApplicationManager* application_manager,
35 const GURL& url, 35 const GURL& url,
36 ScopedMessagePipeHandle shell_handle, 36 ShellPtr shell,
37 LoadCallback callback) override { 37 LoadCallback callback) override {
38 NOTREACHED(); 38 NOTREACHED();
39 } 39 }
40 40
41 void OnApplicationError(ApplicationManager* manager, 41 void OnApplicationError(ApplicationManager* manager,
42 const GURL& url) override { 42 const GURL& url) override {
43 NOTREACHED(); 43 NOTREACHED();
44 } 44 }
45 }; 45 };
46 46
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 run_loop_.Run(); 241 run_loop_.Run();
242 242
243 // The apps need to be destroyed on the thread where they did socket stuff. 243 // The apps need to be destroyed on the thread where they did socket stuff.
244 io_thread_.task_runner()->PostTask( 244 io_thread_.task_runner()->PostTask(
245 FROM_HERE, base::Bind(&DestroyOnIOThread, base::Passed(&supersweet_app), 245 FROM_HERE, base::Bind(&DestroyOnIOThread, base::Passed(&supersweet_app),
246 base::Passed(&awesome_app))); 246 base::Passed(&awesome_app)));
247 } 247 }
248 248
249 } // namespace shell 249 } // namespace shell
250 } // namespace mojo 250 } // namespace mojo
OLDNEW
« no previous file with comments | « shell/dynamic_application_loader_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698