shell/android/background_application_loader.h - Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: shell/android/background_application_loader.h

Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: fix android Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: shell/android/background_application_loader.h

diff --git a/shell/android/background_application_loader.h b/shell/android/background_application_loader.h

index 4650ed6100570d4686c44f17681f3eca7ba67046..26280e84bacc2c1beee87cb4992d7804030fdc71 100644

--- a/shell/android/background_application_loader.h

+++ b/shell/android/background_application_loader.h

@@ -26,7 +26,7 @@ class MOJO_APPLICATION_MANAGER_EXPORT BackgroundApplicationLoader

// ApplicationLoader overrides:

void Load(ApplicationManager* manager,

const GURL& url,

- ScopedMessagePipeHandle shell_handle,

+ ShellPtr shell,

LoadCallback callback) override;

void OnApplicationError(ApplicationManager* manager,

const GURL& url) override;

@@ -41,7 +41,7 @@ class MOJO_APPLICATION_MANAGER_EXPORT BackgroundApplicationLoader

// isn't thread safe).

void LoadOnBackgroundThread(ApplicationManager* manager,

const GURL& url,

- ScopedMessagePipeHandle shell_handle);

+ ShellPtr shell);

void OnApplicationErrorOnBackgroundThread(ApplicationManager* manager,

const GURL& url);

bool quit_on_shutdown_;