Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: shell/android/android_handler_loader.cc

Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « shell/android/android_handler_loader.h ('k') | shell/android/background_application_loader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "shell/android/android_handler_loader.h" 5 #include "shell/android/android_handler_loader.h"
6 6
7 namespace mojo { 7 namespace mojo {
8 namespace shell { 8 namespace shell {
9 9
10 AndroidHandlerLoader::AndroidHandlerLoader() { 10 AndroidHandlerLoader::AndroidHandlerLoader() {
11 } 11 }
12 12
13 AndroidHandlerLoader::~AndroidHandlerLoader() { 13 AndroidHandlerLoader::~AndroidHandlerLoader() {
14 } 14 }
15 15
16 void AndroidHandlerLoader::Load(ApplicationManager* manager, 16 void AndroidHandlerLoader::Load(ApplicationManager* manager,
17 const GURL& url, 17 const GURL& url,
18 ScopedMessagePipeHandle shell_handle, 18 ShellPtr shell,
19 LoadCallback callback) { 19 LoadCallback callback) {
20 DCHECK(shell_handle.is_valid()); 20 DCHECK(shell);
21 application_.reset( 21 application_.reset(new ApplicationImpl(&android_handler_, shell.Pass()));
22 new ApplicationImpl(&android_handler_, shell_handle.Pass()));
23 } 22 }
24 23
25 void AndroidHandlerLoader::OnApplicationError(ApplicationManager* manager, 24 void AndroidHandlerLoader::OnApplicationError(ApplicationManager* manager,
26 const GURL& url) { 25 const GURL& url) {
27 } 26 }
28 27
29 } // namespace shell 28 } // namespace shell
30 } // namespace mojo 29 } // namespace mojo
OLDNEW
« no previous file with comments | « shell/android/android_handler_loader.h ('k') | shell/android/background_application_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698