Improve comments on WebContentsObserver RenderFrame* methods and rename.

Improve comments on WebContentsObserver RenderFrame* methods and rename.

This CL is the first step in a series of CLs to improve the WebContentsObserver interface and make it more consistent for RenderFrame(Host) notifications. It renames FrameDetached to FrameDeleted, to make it more generic and improved comments to reflect what objects the notification is about.

BUG=450799
Committed: https://crrev.com/0052825251b5523c2d422c04651c376d97888dac
Cr-Commit-Position: refs/heads/master@{#312534}

[nasko, 2015-01-21 23:06:13]

nasko@chromium.org changed reviewers:
+ creis@chromium.org

[nasko, 2015-01-21 23:06:14]

Hey Charlie,
Can you review this CL for me? It doesn't contain any code changes, mostly
fixing up comments and renaming FrameDetached.
Thanks in advance!
Nasko

[Charlie Reis, 2015-01-22 00:17:16]

Great.  I'm glad to see this getting saner and more precise.

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
content/public/browser/web_contents.h:197: // IsRenderFrameLive, as sending IPC
messages to it will fail silently.
nit: to it in this case

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
File content/public/browser/web_contents_observer.h (right):

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
content/public/browser/web_contents_observer.h:51: // Called when a RenderFrame
corresponding to the |render_frame_host| is
nit: Called when a RenderFrame for |render_frame_host| is

Also add:
Use |RenderFrameDeleted| to listen for when this RenderFrame goes away.

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
content/public/browser/web_contents_observer.h:55: // Called when a RenderFrame
corresponding to the |render_frame_host| is
Same nit, and mention RenderFrameCreated so that the two methods have references
to each other.  (Seems likely that people will usually want to override both,
not just one.)

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
content/public/browser/web_contents_observer.h:66: // This method, in
combination with FrameDeleted, is appropriate for
nit: |FrameDeleted|

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
content/public/browser/web_contents_observer.h:73: // deleted or the WebContents
is destroyed and the top-level frame is deleted.
Also mention |RenderFrameHostChanged|, so that the pair of methods have
references to each other.

[nasko, 2015-01-22 00:27:23]

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
content/public/browser/web_contents.h:197: // IsRenderFrameLive, as sending IPC
messages to it will fail silently.
On 2015/01/22 00:17:15, Charlie Reis wrote:
> nit: to it in this case

Done.

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
File content/public/browser/web_contents_observer.h (right):

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
content/public/browser/web_contents_observer.h:51: // Called when a RenderFrame
corresponding to the |render_frame_host| is
On 2015/01/22 00:17:15, Charlie Reis wrote:
> nit: Called when a RenderFrame for |render_frame_host| is
> 
> Also add:
> Use |RenderFrameDeleted| to listen for when this RenderFrame goes away.

Done.

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
content/public/browser/web_contents_observer.h:55: // Called when a RenderFrame
corresponding to the |render_frame_host| is
On 2015/01/22 00:17:16, Charlie Reis wrote:
> Same nit, and mention RenderFrameCreated so that the two methods have
references
> to each other.  (Seems likely that people will usually want to override both,
> not just one.)

Done.

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
content/public/browser/web_contents_observer.h:66: // This method, in
combination with FrameDeleted, is appropriate for
On 2015/01/22 00:17:16, Charlie Reis wrote:
> nit: |FrameDeleted|

Done.

https://codereview.chromium.org/865723002/diff/1/content/public/browser/web_c...
content/public/browser/web_contents_observer.h:73: // deleted or the WebContents
is destroyed and the top-level frame is deleted.
On 2015/01/22 00:17:15, Charlie Reis wrote:
> Also mention |RenderFrameHostChanged|, so that the pair of methods have
> references to each other.

Done.

[Charlie Reis, 2015-01-22 00:50:34]

Thanks!  LGTM.

https://codereview.chromium.org/865723002/diff/20001/content/public/browser/w...
File content/public/browser/web_contents_observer.h (right):

https://codereview.chromium.org/865723002/diff/20001/content/public/browser/w...
content/public/browser/web_contents_observer.h:76: // Use
|RenderFrameHostChanged| to listen for when RenderFrameHost object is
nit: when a

[nasko, 2015-01-22 00:52:09]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2015-01-22 00:53:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/865723002/40001

[commit-bot: I haz the power, 2015-01-22 02:30:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-22 02:31:18]

Patchset 3 (id:??) landed as
https://crrev.com/0052825251b5523c2d422c04651c376d97888dac
Cr-Commit-Position: refs/heads/master@{#312534}