content/public/test/web_contents_observer_sanity_checker.h - Issue 865723002: Improve comments on WebContentsObserver RenderFrame* methods and rename.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/web_contents_observer_sanity_checker.h

Issue 865723002: Improve comments on WebContentsObserver RenderFrame* methods and rename. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing a nit. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/test/web_contents_observer_sanity_checker.h

diff --git a/content/public/test/web_contents_observer_sanity_checker.h b/content/public/test/web_contents_observer_sanity_checker.h

index 991ad66a38c91690c14722ad2a8aaaa95b0f5ebd..2d702d0859e34184f694cf7fd666279e6be5fc3d 100644

--- a/content/public/test/web_contents_observer_sanity_checker.h

+++ b/content/public/test/web_contents_observer_sanity_checker.h

@@ -39,6 +39,7 @@ class WebContentsObserverSanityChecker : public WebContentsObserver,

RenderFrameHost* render_frame_host) override;

void RenderFrameHostChanged(RenderFrameHost* old_host,

RenderFrameHost* new_host) override;

+ void FrameDeleted(RenderFrameHost* render_frame_host) override;

void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,

const GURL& validated_url,

bool is_error_page,

@@ -74,7 +75,6 @@ class WebContentsObserverSanityChecker : public WebContentsObserver,

const Referrer& referrer,

WindowOpenDisposition disposition,

ui::PageTransition transition) override;

- void FrameDetached(RenderFrameHost* render_frame_host) override;

bool OnMessageReceived(const IPC::Message& message,

RenderFrameHost* render_frame_host) override;

void WebContentsDestroyed() override;

« no previous file with comments | « content/public/browser/web_contents_observer.h ('k') | content/public/test/web_contents_observer_sanity_checker.cc » ('j') | no next file with comments »