Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2819)

Unified Diff: content/public/test/web_contents_observer_sanity_checker.cc

Issue 865723002: Improve comments on WebContentsObserver RenderFrame* methods and rename. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing a nit. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/web_contents_observer_sanity_checker.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/web_contents_observer_sanity_checker.cc
diff --git a/content/public/test/web_contents_observer_sanity_checker.cc b/content/public/test/web_contents_observer_sanity_checker.cc
index 30bc6041c178ae9d319ca4898e7ca39a5d6d0d34..554992a9716d3ecdfda82103740401d18145759e 100644
--- a/content/public/test/web_contents_observer_sanity_checker.cc
+++ b/content/public/test/web_contents_observer_sanity_checker.cc
@@ -87,6 +87,11 @@ void WebContentsObserverSanityChecker::RenderFrameHostChanged(
AssertFrameExists(new_host);
}
+void WebContentsObserverSanityChecker::FrameDeleted(
+ RenderFrameHost* render_frame_host) {
+ AssertFrameExists(render_frame_host);
+}
+
void WebContentsObserverSanityChecker::DidStartProvisionalLoadForFrame(
RenderFrameHost* render_frame_host,
const GURL& validated_url,
@@ -166,11 +171,6 @@ void WebContentsObserverSanityChecker::DidOpenRequestedURL(
AssertFrameExists(source_render_frame_host);
}
-void WebContentsObserverSanityChecker::FrameDetached(
- RenderFrameHost* render_frame_host) {
- AssertFrameExists(render_frame_host);
-}
-
bool WebContentsObserverSanityChecker::OnMessageReceived(
const IPC::Message& message,
RenderFrameHost* render_frame_host) {
« no previous file with comments | « content/public/test/web_contents_observer_sanity_checker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698