Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Side by Side Diff: content/public/browser/web_contents.h

Issue 865723002: Improve comments on WebContentsObserver RenderFrame* methods and rename. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 // these may change over time. 185 // these may change over time.
186 virtual RenderProcessHost* GetRenderProcessHost() const = 0; 186 virtual RenderProcessHost* GetRenderProcessHost() const = 0;
187 187
188 // Returns the main frame for the currently active view. 188 // Returns the main frame for the currently active view.
189 virtual RenderFrameHost* GetMainFrame() = 0; 189 virtual RenderFrameHost* GetMainFrame() = 0;
190 190
191 // Returns the focused frame for the currently active view. 191 // Returns the focused frame for the currently active view.
192 virtual RenderFrameHost* GetFocusedFrame() = 0; 192 virtual RenderFrameHost* GetFocusedFrame() = 0;
193 193
194 // Calls |on_frame| for each frame in the currently active view. 194 // Calls |on_frame| for each frame in the currently active view.
195 // Note: The RenderFrameHost parameter is not guaranteed to have a live
196 // RenderFrame counterpart in the renderer process. Callbacks should check
197 // IsRenderFrameLive, as sending IPC messages to it will fail silently.
Charlie Reis 2015/01/22 00:17:15 nit: to it in this case
nasko 2015/01/22 00:27:23 Done.
195 virtual void ForEachFrame( 198 virtual void ForEachFrame(
196 const base::Callback<void(RenderFrameHost*)>& on_frame) = 0; 199 const base::Callback<void(RenderFrameHost*)>& on_frame) = 0;
197 200
198 // Sends the given IPC to all frames in the currently active view. This is a 201 // Sends the given IPC to all frames in the currently active view. This is a
199 // convenience method instead of calling ForEach. 202 // convenience method instead of calling ForEach.
200 virtual void SendToAllFrames(IPC::Message* message) = 0; 203 virtual void SendToAllFrames(IPC::Message* message) = 0;
201 204
202 // Gets the current RenderViewHost for this tab. 205 // Gets the current RenderViewHost for this tab.
203 virtual RenderViewHost* GetRenderViewHost() const = 0; 206 virtual RenderViewHost* GetRenderViewHost() const = 0;
204 207
(...skipping 409 matching lines...) Expand 10 before | Expand all | Expand 10 after
614 617
615 private: 618 private:
616 // This interface should only be implemented inside content. 619 // This interface should only be implemented inside content.
617 friend class WebContentsImpl; 620 friend class WebContentsImpl;
618 WebContents() {} 621 WebContents() {}
619 }; 622 };
620 623
621 } // namespace content 624 } // namespace content
622 625
623 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 626 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698