Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Side by Side Diff: content/public/test/web_contents_observer_sanity_checker.cc

Issue 865723002: Improve comments on WebContentsObserver RenderFrame* methods and rename. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing a nit. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/test/web_contents_observer_sanity_checker.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/test/web_contents_observer_sanity_checker.h" 5 #include "content/public/test/web_contents_observer_sanity_checker.h"
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "content/public/browser/render_frame_host.h" 8 #include "content/public/browser/render_frame_host.h"
9 #include "content/public/browser/render_process_host.h" 9 #include "content/public/browser/render_process_host.h"
10 #include "content/public/browser/site_instance.h" 10 #include "content/public/browser/site_instance.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 80
81 void WebContentsObserverSanityChecker::RenderFrameHostChanged( 81 void WebContentsObserverSanityChecker::RenderFrameHostChanged(
82 RenderFrameHost* old_host, 82 RenderFrameHost* old_host,
83 RenderFrameHost* new_host) { 83 RenderFrameHost* new_host) {
84 CHECK(new_host); 84 CHECK(new_host);
85 if (old_host) 85 if (old_host)
86 AssertFrameExists(old_host); 86 AssertFrameExists(old_host);
87 AssertFrameExists(new_host); 87 AssertFrameExists(new_host);
88 } 88 }
89 89
90 void WebContentsObserverSanityChecker::FrameDeleted(
91 RenderFrameHost* render_frame_host) {
92 AssertFrameExists(render_frame_host);
93 }
94
90 void WebContentsObserverSanityChecker::DidStartProvisionalLoadForFrame( 95 void WebContentsObserverSanityChecker::DidStartProvisionalLoadForFrame(
91 RenderFrameHost* render_frame_host, 96 RenderFrameHost* render_frame_host,
92 const GURL& validated_url, 97 const GURL& validated_url,
93 bool is_error_page, 98 bool is_error_page,
94 bool is_iframe_srcdoc) { 99 bool is_iframe_srcdoc) {
95 AssertFrameExists(render_frame_host); 100 AssertFrameExists(render_frame_host);
96 } 101 }
97 102
98 void WebContentsObserverSanityChecker::DidCommitProvisionalLoadForFrame( 103 void WebContentsObserverSanityChecker::DidCommitProvisionalLoadForFrame(
99 RenderFrameHost* render_frame_host, 104 RenderFrameHost* render_frame_host,
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 void WebContentsObserverSanityChecker::DidOpenRequestedURL( 164 void WebContentsObserverSanityChecker::DidOpenRequestedURL(
160 WebContents* new_contents, 165 WebContents* new_contents,
161 RenderFrameHost* source_render_frame_host, 166 RenderFrameHost* source_render_frame_host,
162 const GURL& url, 167 const GURL& url,
163 const Referrer& referrer, 168 const Referrer& referrer,
164 WindowOpenDisposition disposition, 169 WindowOpenDisposition disposition,
165 ui::PageTransition transition) { 170 ui::PageTransition transition) {
166 AssertFrameExists(source_render_frame_host); 171 AssertFrameExists(source_render_frame_host);
167 } 172 }
168 173
169 void WebContentsObserverSanityChecker::FrameDetached(
170 RenderFrameHost* render_frame_host) {
171 AssertFrameExists(render_frame_host);
172 }
173
174 bool WebContentsObserverSanityChecker::OnMessageReceived( 174 bool WebContentsObserverSanityChecker::OnMessageReceived(
175 const IPC::Message& message, 175 const IPC::Message& message,
176 RenderFrameHost* render_frame_host) { 176 RenderFrameHost* render_frame_host) {
177 #if !defined(OS_MACOSX) 177 #if !defined(OS_MACOSX)
178 // TODO(avi): Disabled because of http://crbug.com/445054 178 // TODO(avi): Disabled because of http://crbug.com/445054
179 AssertFrameExists(render_frame_host); 179 AssertFrameExists(render_frame_host);
180 #endif 180 #endif
181 return false; 181 return false;
182 } 182 }
183 183
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 223
224 std::string WebContentsObserverSanityChecker::Format( 224 std::string WebContentsObserverSanityChecker::Format(
225 RenderFrameHost* render_frame_host) { 225 RenderFrameHost* render_frame_host) {
226 return base::StringPrintf( 226 return base::StringPrintf(
227 "(%d, %d -> %s )", render_frame_host->GetProcess()->GetID(), 227 "(%d, %d -> %s )", render_frame_host->GetProcess()->GetID(),
228 render_frame_host->GetRoutingID(), 228 render_frame_host->GetRoutingID(),
229 render_frame_host->GetSiteInstance()->GetSiteURL().spec().c_str()); 229 render_frame_host->GetSiteInstance()->GetSiteURL().spec().c_str());
230 } 230 }
231 231
232 } // namespace content 232 } // namespace content
OLDNEW
« no previous file with comments | « content/public/test/web_contents_observer_sanity_checker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698