Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: content/public/test/web_contents_observer_sanity_checker.h

Issue 865723002: Improve comments on WebContentsObserver RenderFrame* methods and rename. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing a nit. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_ 5 #ifndef CONTENT_PUBLIC_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_
6 #define CONTENT_PUBLIC_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_ 6 #define CONTENT_PUBLIC_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 21 matching lines...) Expand all
32 // should call this for you. 32 // should call this for you.
33 static void Enable(WebContents* web_contents); 33 static void Enable(WebContents* web_contents);
34 34
35 // WebContentsObserver implementation. 35 // WebContentsObserver implementation.
36 void RenderFrameCreated(RenderFrameHost* render_frame_host) override; 36 void RenderFrameCreated(RenderFrameHost* render_frame_host) override;
37 void RenderFrameDeleted(RenderFrameHost* render_frame_host) override; 37 void RenderFrameDeleted(RenderFrameHost* render_frame_host) override;
38 void RenderFrameForInterstitialPageCreated( 38 void RenderFrameForInterstitialPageCreated(
39 RenderFrameHost* render_frame_host) override; 39 RenderFrameHost* render_frame_host) override;
40 void RenderFrameHostChanged(RenderFrameHost* old_host, 40 void RenderFrameHostChanged(RenderFrameHost* old_host,
41 RenderFrameHost* new_host) override; 41 RenderFrameHost* new_host) override;
42 void FrameDeleted(RenderFrameHost* render_frame_host) override;
42 void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host, 43 void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,
43 const GURL& validated_url, 44 const GURL& validated_url,
44 bool is_error_page, 45 bool is_error_page,
45 bool is_iframe_srcdoc) override; 46 bool is_iframe_srcdoc) override;
46 void DidCommitProvisionalLoadForFrame( 47 void DidCommitProvisionalLoadForFrame(
47 RenderFrameHost* render_frame_host, 48 RenderFrameHost* render_frame_host,
48 const GURL& url, 49 const GURL& url,
49 ui::PageTransition transition_type) override; 50 ui::PageTransition transition_type) override;
50 void DidFailProvisionalLoad(RenderFrameHost* render_frame_host, 51 void DidFailProvisionalLoad(RenderFrameHost* render_frame_host,
51 const GURL& validated_url, 52 const GURL& validated_url,
(...skipping 15 matching lines...) Expand all
67 const base::string16& error_description) override; 68 const base::string16& error_description) override;
68 void DidGetRedirectForResourceRequest( 69 void DidGetRedirectForResourceRequest(
69 RenderFrameHost* render_frame_host, 70 RenderFrameHost* render_frame_host,
70 const ResourceRedirectDetails& details) override; 71 const ResourceRedirectDetails& details) override;
71 void DidOpenRequestedURL(WebContents* new_contents, 72 void DidOpenRequestedURL(WebContents* new_contents,
72 RenderFrameHost* source_render_frame_host, 73 RenderFrameHost* source_render_frame_host,
73 const GURL& url, 74 const GURL& url,
74 const Referrer& referrer, 75 const Referrer& referrer,
75 WindowOpenDisposition disposition, 76 WindowOpenDisposition disposition,
76 ui::PageTransition transition) override; 77 ui::PageTransition transition) override;
77 void FrameDetached(RenderFrameHost* render_frame_host) override;
78 bool OnMessageReceived(const IPC::Message& message, 78 bool OnMessageReceived(const IPC::Message& message,
79 RenderFrameHost* render_frame_host) override; 79 RenderFrameHost* render_frame_host) override;
80 void WebContentsDestroyed() override; 80 void WebContentsDestroyed() override;
81 81
82 private: 82 private:
83 explicit WebContentsObserverSanityChecker(WebContents* web_contents); 83 explicit WebContentsObserverSanityChecker(WebContents* web_contents);
84 ~WebContentsObserverSanityChecker() override; 84 ~WebContentsObserverSanityChecker() override;
85 85
86 std::string Format(RenderFrameHost* render_frame_host); 86 std::string Format(RenderFrameHost* render_frame_host);
87 void AssertFrameExists(RenderFrameHost* render_frame_host); 87 void AssertFrameExists(RenderFrameHost* render_frame_host);
88 void AssertMainFrameExists(); 88 void AssertMainFrameExists();
89 89
90 std::set<std::pair<int, int>> live_routes_; 90 std::set<std::pair<int, int>> live_routes_;
91 std::set<std::pair<int, int>> deleted_routes_; 91 std::set<std::pair<int, int>> deleted_routes_;
92 bool web_contents_destroyed_; 92 bool web_contents_destroyed_;
93 93
94 DISALLOW_COPY_AND_ASSIGN(WebContentsObserverSanityChecker); 94 DISALLOW_COPY_AND_ASSIGN(WebContentsObserverSanityChecker);
95 }; 95 };
96 96
97 } // namespace content 97 } // namespace content
98 98
99 #endif // CONTENT_PUBLIC_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_ 99 #endif // CONTENT_PUBLIC_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_
OLDNEW
« no previous file with comments | « content/public/browser/web_contents_observer.h ('k') | content/public/test/web_contents_observer_sanity_checker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698