content/browser/web_contents/web_contents_impl.cc - Issue 865723002: Improve comments on WebContentsObserver RenderFrame* methods and rename.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 865723002: Improve comments on WebContentsObserver RenderFrame* methods and rename. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing a nit. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 5b891f5487de5e086e1618da88c14d677e59a059..1cfaad21f754aa89fff43894db5e3f831159627f 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -4385,7 +4385,7 @@ gfx::Size WebContentsImpl::GetSizeForNewRenderView() {

void WebContentsImpl::OnFrameRemoved(RenderFrameHost* render_frame_host) {

FOR_EACH_OBSERVER(

- WebContentsObserver, observers_, FrameDetached(render_frame_host));

+ WebContentsObserver, observers_, FrameDeleted(render_frame_host));

}

void WebContentsImpl::OnPreferredSizeChanged(const gfx::Size& old_size) {

« no previous file with comments | « no previous file | content/public/browser/web_contents.h » ('j') | no next file with comments »