Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 855023003: Add presubmit check for scoped_ptr usage. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, ozone-reviews_chromium.org, tdanderson+views_chromium.org, msw+watch_chromium.org, sadrul, tdresser+watch_chromium.org, mlamouri+watch-notifications_chromium.org, kalyank, peter+watch_chromium.org, alicet1, jdduke+watch_chromium.org, danakj, dewittj, tapted, M-A Ruel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add presubmit check for scoped_ptr usage. The entries were all found by the following command line: $ g grep -nE '\bscoped_ptr<.*?>\(\)' ui/ BUG=None TEST=app_list_unittests, aura_unittests, events_unittests, message_center_unittests,views_unittests, ... R=sky@chromium.org Committed: https://crrev.com/92cf0d48483c8c41f273a8e4a3843cd9552873ee Cr-Commit-Position: refs/heads/master@{#312885}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : remove presubmit script #

Patch Set 5 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -37 lines) Patch
M ui/app_list/search/dictionary_data_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/search/history_data_store.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/app_list/test/test_search_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/event_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/device/udev/device_manager_udev.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/events/platform/platform_event_source_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/test/test_event_target.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/x/events_x_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/message_center_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/toast_contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/caca/caca_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/test/test_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/public/surface_factory_ozone.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_cursor_loader_updater_aurawin.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/nested_accelerator_dispatcher_linux.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
tfarina
sky -> ui/ review! CCing Dana, as this ports a presubmit from cc/, fyi. CCing ...
5 years, 11 months ago (2015-01-21 21:38:38 UTC) #1
sky
Can you land the script separately please?
5 years, 11 months ago (2015-01-21 22:47:46 UTC) #2
tfarina
On 2015/01/21 22:47:46, sky wrote: > Can you land the script separately please?
5 years, 11 months ago (2015-01-22 21:57:24 UTC) #3
tfarina
On 2015/01/21 22:47:46, sky wrote: > Can you land the script separately please? Yup. Done.
5 years, 11 months ago (2015-01-22 21:57:36 UTC) #4
sky
LGTM
5 years, 11 months ago (2015-01-23 00:36:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855023003/80001
5 years, 11 months ago (2015-01-23 17:07:37 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-23 18:56:15 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 18:57:17 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/92cf0d48483c8c41f273a8e4a3843cd9552873ee
Cr-Commit-Position: refs/heads/master@{#312885}

Powered by Google App Engine
This is Rietveld 408576698