ui/message_center/views/notification_view_unittest.cc - Issue 855023003: Add presubmit check for scoped_ptr usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/views/notification_view_unittest.cc

Issue 855023003: Add presubmit check for scoped_ptr usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/message_center/views/notification_view_unittest.cc

diff --git a/ui/message_center/views/notification_view_unittest.cc b/ui/message_center/views/notification_view_unittest.cc

index 3977f5fbb67ce3acbf2221983d2213ab43d4e0d4..d4c155b1166ce21d1982aee2daecfe4ea293d480 100644

--- a/ui/message_center/views/notification_view_unittest.cc

+++ b/ui/message_center/views/notification_view_unittest.cc

@@ -162,7 +162,7 @@ scoped_ptr<ui::MenuModel> NotificationViewTest::CreateMenuModel(

const base::string16& display_source) {

// For this test, this method should not be invoked.

NOTREACHED();

- return scoped_ptr<ui::MenuModel>();

+ return nullptr;

}

bool NotificationViewTest::HasClickedListener(