ui/views/controls/button/label_button.cc - Issue 855023003: Add presubmit check for scoped_ptr usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/label_button.cc

Issue 855023003: Add presubmit check for scoped_ptr usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/button/label_button.cc

diff --git a/ui/views/controls/button/label_button.cc b/ui/views/controls/button/label_button.cc

index 52250cfac08d6e175be67dbd5dd031e1490b8747..0387e1d641e64caa1bb93dc934811e27945bee58 100644

--- a/ui/views/controls/button/label_button.cc

+++ b/ui/views/controls/button/label_button.cc

@@ -191,7 +191,7 @@ void LabelButton::SetStyle(ButtonStyle style) {

style_ = style;

// Inset the button focus rect from the actual border; roughly match Windows.

if (style == STYLE_BUTTON) {

- SetFocusPainter(scoped_ptr<Painter>());

+ SetFocusPainter(nullptr);

} else {

SetFocusPainter(Painter::CreateDashedFocusPainterWithInsets(

gfx::Insets(3, 3, 3, 3)));