ui/events/x/events_x_unittest.cc - Issue 855023003: Add presubmit check for scoped_ptr usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/x/events_x_unittest.cc

Issue 855023003: Add presubmit check for scoped_ptr usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/x/events_x_unittest.cc

diff --git a/ui/events/x/events_x_unittest.cc b/ui/events/x/events_x_unittest.cc

index 065e804e39b6a71d5d35116a4bc34bffe998c630..fb74424240d36286211b51a543899fcefcac1a0a 100644

--- a/ui/events/x/events_x_unittest.cc

+++ b/ui/events/x/events_x_unittest.cc

@@ -553,8 +553,7 @@ TEST_F(EventsXTest, DisableKeyboard) {

EXPECT_EQ(ui::ET_KEY_PRESSED, ui::EventTypeFromNative(xev));

device_data_manager->EnableDevice(blocked_device_id);

- device_data_manager->SetDisabledKeyboardAllowedKeys(

- scoped_ptr<std::set<KeyboardCode> >());

+ device_data_manager->SetDisabledKeyboardAllowedKeys(nullptr);

// A key returns KEY_PRESSED as per usual now that keyboard was re-enabled.

xev.InitGenericKeyEvent(master_device_id,

« no previous file with comments | « ui/events/test/test_event_target.cc ('k') | ui/gl/gl_surface_egl.cc » ('j') | no next file with comments »