ui/message_center/views/toast_contents_view.cc - Issue 855023003: Add presubmit check for scoped_ptr usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/views/toast_contents_view.cc

Issue 855023003: Add presubmit check for scoped_ptr usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/message_center/views/toast_contents_view.cc

diff --git a/ui/message_center/views/toast_contents_view.cc b/ui/message_center/views/toast_contents_view.cc

index fd753571386fe655f9d48bb19c9aee03cba5d63c..bd98d032dcdd0a4b626667ba971e6aaa5aff3f05 100644

--- a/ui/message_center/views/toast_contents_view.cc

+++ b/ui/message_center/views/toast_contents_view.cc

@@ -307,7 +307,7 @@ scoped_ptr<ui::MenuModel> ToastContentsView::CreateMenuModel(

// Should not reach, the context menu should be handled in

// MessagePopupCollection.

NOTREACHED();

- return scoped_ptr<ui::MenuModel>();

+ return nullptr;

}

bool ToastContentsView::HasClickedListener(