ui/views/bubble/bubble_frame_view.cc - Issue 855023003: Add presubmit check for scoped_ptr usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_frame_view.cc

Issue 855023003: Add presubmit check for scoped_ptr usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/bubble/bubble_frame_view.cc

diff --git a/ui/views/bubble/bubble_frame_view.cc b/ui/views/bubble/bubble_frame_view.cc

index e3eb3c8999ec62ed16e1b8d663095aa3e72e15a2..88628fbb75137774127b2bb6f31e4bc0cac9f532 100644

--- a/ui/views/bubble/bubble_frame_view.cc

+++ b/ui/views/bubble/bubble_frame_view.cc

@@ -92,7 +92,7 @@ LabelButton* BubbleFrameView::CreateCloseButton(ButtonListener* listener) {

*rb.GetImageNamed(IDR_CLOSE_DIALOG_H).ToImageSkia());

close->SetImage(CustomButton::STATE_PRESSED,

*rb.GetImageNamed(IDR_CLOSE_DIALOG_P).ToImageSkia());

- close->SetBorder(scoped_ptr<Border>());

+ close->SetBorder(nullptr);

close->SetSize(close->GetPreferredSize());

return close;

}

« no previous file with comments | « ui/ozone/public/surface_factory_ozone.cc ('k') | ui/views/controls/button/label_button.cc » ('j') | no next file with comments »