ui/ozone/platform/dri/gbm_surface_factory.cc - Issue 855023003: Add presubmit check for scoped_ptr usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/ozone/platform/dri/gbm_surface_factory.cc

Issue 855023003: Add presubmit check for scoped_ptr usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/ozone/platform/dri/gbm_surface_factory.cc

diff --git a/ui/ozone/platform/dri/gbm_surface_factory.cc b/ui/ozone/platform/dri/gbm_surface_factory.cc

index 293d8aee10c6f3ec2a98c77b06fc5b10065cdf54..c5da63dfeb946fde87e5f6d217c36a3ad0f52951 100644

--- a/ui/ozone/platform/dri/gbm_surface_factory.cc

+++ b/ui/ozone/platform/dri/gbm_surface_factory.cc

@@ -134,7 +134,7 @@ scoped_ptr<SurfaceOzoneEGL>

GbmSurfaceFactory::CreateSurfacelessEGLSurfaceForWidget(

gfx::AcceleratedWidget widget) {

if (!allow_surfaceless_)

- return scoped_ptr<SurfaceOzoneEGL>();

+ return nullptr;

DriWindowDelegate* delegate = GetOrCreateWindowDelegate(widget);

return scoped_ptr<SurfaceOzoneEGL>(new GbmSurfaceless(delegate));