Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 837453003: Chromecast: virtual/override cleanup. (Closed)

Created:
5 years, 11 months ago by gunsch
Modified:
5 years, 11 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, eme-reviews_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, kalyank, gunsch+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: virtual/override cleanup. See: https://codereview.chromium.org/831863003 R=lcwu@chromium.org BUG=417463 Committed: https://crrev.com/7f9fc2234d79c5422fc538fa9337d4378c08363a Cr-Commit-Position: refs/heads/master@{#310131}

Patch Set 1 #

Patch Set 2 : missed a few spots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -303 lines) Patch
M chromecast/app/cast_main_delegate.h View 1 chunk +7 lines, -8 lines 0 comments Download
M chromecast/base/metrics/cast_metrics_test_helper.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M chromecast/browser/cast_browser_context.h View 1 chunk +17 lines, -19 lines 0 comments Download
M chromecast/browser/cast_browser_context.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 1 3 chunks +18 lines, -20 lines 0 comments Download
M chromecast/browser/cast_content_window.cc View 1 1 chunk +9 lines, -9 lines 0 comments Download
M chromecast/browser/cast_download_manager_delegate.h View 1 2 chunks +7 lines, -9 lines 0 comments Download
M chromecast/browser/cast_http_user_agent_settings.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chromecast/browser/cast_network_delegate.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chromecast/browser/cast_network_delegate_simple.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chromecast/browser/devtools/cast_dev_tools_delegate.h View 1 2 chunks +8 lines, -9 lines 0 comments Download
M chromecast/browser/devtools/cast_dev_tools_delegate.cc View 1 2 chunks +12 lines, -23 lines 0 comments Download
M chromecast/browser/devtools/remote_debugging_server.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/browser/geolocation/cast_access_token_store.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.h View 1 2 chunks +12 lines, -13 lines 0 comments Download
M chromecast/browser/metrics/cast_stability_metrics_provider.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
M chromecast/browser/test/chromecast_browser_test.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromecast/browser/test/chromecast_browser_test_runner.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chromecast/browser/test/chromecast_shell_browser_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/url_request_context_factory.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M chromecast/common/cast_content_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chromecast/common/cast_resource_delegate.h View 1 1 chunk +11 lines, -13 lines 0 comments Download
M chromecast/crash/cast_crash_reporter_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromecast/media/base/decrypt_context_clearkey.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chromecast/media/cdm/browser_cdm_cast.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/backend/audio_pipeline_device.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/backend/media_pipeline_device_fake.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chromecast/media/cma/backend/media_pipeline_device_fake.cc View 4 chunks +37 lines, -37 lines 0 comments Download
M chromecast/media/cma/backend/video_pipeline_device.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/backend/video_plane_fake.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/base/balanced_media_task_runner_factory.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chromecast/media/cma/base/balanced_media_task_runner_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/base/buffering_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/base/buffering_frame_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromecast/media/cma/base/buffering_frame_provider_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/base/decoder_buffer_adapter.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chromecast/media/cma/filters/demuxer_stream_adapter.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chromecast/media/cma/filters/demuxer_stream_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/media/cma/filters/demuxer_stream_adapter_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/media/cma/ipc/media_message_fifo.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chromecast/media/cma/ipc/media_message_fifo_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chromecast/media/cma/ipc/media_message_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chromecast/media/cma/ipc_streamer/av_streamer_unittest.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chromecast/media/cma/ipc_streamer/coded_frame_provider_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromecast/media/cma/ipc_streamer/decoder_buffer_base_marshaller.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/pipeline/decrypt_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/test/frame_segmenter_for_test.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M chromecast/media/cma/test/mock_frame_provider.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chromecast/media/cma/test/run_all_unittests.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/net/network_change_notifier_cast.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/net/network_change_notifier_factory_cast.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
gunsch
5 years, 11 months ago (2015-01-05 18:53:42 UTC) #1
lcwu1
lgtm
5 years, 11 months ago (2015-01-06 19:09:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837453003/20001
5 years, 11 months ago (2015-01-06 19:11:53 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 20:20:34 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 20:22:25 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7f9fc2234d79c5422fc538fa9337d4378c08363a
Cr-Commit-Position: refs/heads/master@{#310131}

Powered by Google App Engine
This is Rietveld 408576698