Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 837453003: Chromecast: virtual/override cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: missed a few spots Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/metrics/cast_metrics_service_client.h
diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h
index 54973c8af653b5795376685d893483ebafb11282..c9343cb2593511c628c6e9999f848b7375ed29c8 100644
--- a/chromecast/browser/metrics/cast_metrics_service_client.h
+++ b/chromecast/browser/metrics/cast_metrics_service_client.h
@@ -39,7 +39,7 @@ class ExternalMetrics;
class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {
public:
- virtual ~CastMetricsServiceClient();
+ ~CastMetricsServiceClient() override;
static scoped_ptr<CastMetricsServiceClient> Create(
base::TaskRunner* io_task_runner,
@@ -49,18 +49,17 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {
void Initialize(CastService* cast_service);
// metrics::MetricsServiceClient implementation:
- virtual void SetMetricsClientId(const std::string& client_id) override;
- virtual bool IsOffTheRecordSessionActive() override;
- virtual int32_t GetProduct() override;
- virtual std::string GetApplicationLocale() override;
- virtual bool GetBrand(std::string* brand_code) override;
- virtual ::metrics::SystemProfileProto::Channel GetChannel() override;
- virtual std::string GetVersionString() override;
- virtual void OnLogUploadComplete() override;
- virtual void StartGatheringMetrics(
- const base::Closure& done_callback) override;
- virtual void CollectFinalMetrics(const base::Closure& done_callback) override;
- virtual scoped_ptr< ::metrics::MetricsLogUploader> CreateUploader(
+ void SetMetricsClientId(const std::string& client_id) override;
+ bool IsOffTheRecordSessionActive() override;
+ int32_t GetProduct() override;
+ std::string GetApplicationLocale() override;
+ bool GetBrand(std::string* brand_code) override;
+ ::metrics::SystemProfileProto::Channel GetChannel() override;
+ std::string GetVersionString() override;
+ void OnLogUploadComplete() override;
+ void StartGatheringMetrics(const base::Closure& done_callback) override;
+ void CollectFinalMetrics(const base::Closure& done_callback) override;
+ scoped_ptr< ::metrics::MetricsLogUploader> CreateUploader(
const std::string& server_url,
const std::string& mime_type,
const base::Callback<void(int)>& on_upload_complete) override;
« no previous file with comments | « chromecast/browser/geolocation/cast_access_token_store.h ('k') | chromecast/browser/metrics/cast_stability_metrics_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698