chromecast/media/cma/ipc/media_message_unittest.cc - Issue 837453003: Chromecast: virtual/override cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/cma/ipc/media_message_unittest.cc

Issue 837453003: Chromecast: virtual/override cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed a few spots Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/media/cma/ipc/media_message_unittest.cc

diff --git a/chromecast/media/cma/ipc/media_message_unittest.cc b/chromecast/media/cma/ipc/media_message_unittest.cc

index 6f34f3eaf89fbde14c8f10e48a389a43ce7a508c..cec0712cfaa7a84ff2ef2acdd18a1eff893d73ca 100644

--- a/chromecast/media/cma/ipc/media_message_unittest.cc

+++ b/chromecast/media/cma/ipc/media_message_unittest.cc

@@ -19,12 +19,12 @@ class ExternalMemoryBlock

public:

ExternalMemoryBlock(void* data, size_t size)

: data_(data), size_(size) {}

- virtual ~ExternalMemoryBlock() {}

+ ~ExternalMemoryBlock() override {}

// MediaMemoryChunk implementation.

- virtual void* data() const override { return data_; }

- virtual size_t size() const override { return size_; }

- virtual bool valid() const override { return true; }

+ void* data() const override { return data_; }

+ size_t size() const override { return size_; }

+ bool valid() const override { return true; }

private:

void* const data_;