Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: chromecast/browser/devtools/cast_dev_tools_delegate.cc

Issue 837453003: Chromecast: virtual/override cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: missed a few spots Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/browser/devtools/cast_dev_tools_delegate.h" 5 #include "chromecast/browser/devtools/cast_dev_tools_delegate.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "content/public/browser/devtools_agent_host.h" 10 #include "content/public/browser/devtools_agent_host.h"
(...skipping 13 matching lines...) Expand all
24 24
25 const char kTargetTypePage[] = "page"; 25 const char kTargetTypePage[] = "page";
26 const char kTargetTypeServiceWorker[] = "service_worker"; 26 const char kTargetTypeServiceWorker[] = "service_worker";
27 const char kTargetTypeSharedWorker[] = "worker"; 27 const char kTargetTypeSharedWorker[] = "worker";
28 const char kTargetTypeOther[] = "other"; 28 const char kTargetTypeOther[] = "other";
29 29
30 class Target : public content::DevToolsTarget { 30 class Target : public content::DevToolsTarget {
31 public: 31 public:
32 explicit Target(scoped_refptr<content::DevToolsAgentHost> agent_host); 32 explicit Target(scoped_refptr<content::DevToolsAgentHost> agent_host);
33 33
34 virtual std::string GetId() const override { return agent_host_->GetId(); } 34 std::string GetId() const override { return agent_host_->GetId(); }
35 virtual std::string GetParentId() const override { return std::string(); } 35 std::string GetParentId() const override { return std::string(); }
36 virtual std::string GetType() const override { 36 std::string GetType() const override {
37 switch (agent_host_->GetType()) { 37 switch (agent_host_->GetType()) {
38 case content::DevToolsAgentHost::TYPE_WEB_CONTENTS: 38 case content::DevToolsAgentHost::TYPE_WEB_CONTENTS:
39 return kTargetTypePage; 39 return kTargetTypePage;
40 case content::DevToolsAgentHost::TYPE_SERVICE_WORKER: 40 case content::DevToolsAgentHost::TYPE_SERVICE_WORKER:
41 return kTargetTypeServiceWorker; 41 return kTargetTypeServiceWorker;
42 case content::DevToolsAgentHost::TYPE_SHARED_WORKER: 42 case content::DevToolsAgentHost::TYPE_SHARED_WORKER:
43 return kTargetTypeSharedWorker; 43 return kTargetTypeSharedWorker;
44 default: 44 default:
45 break; 45 break;
46 } 46 }
47 return kTargetTypeOther; 47 return kTargetTypeOther;
48 } 48 }
49 virtual std::string GetTitle() const override { 49 std::string GetTitle() const override { return agent_host_->GetTitle(); }
50 return agent_host_->GetTitle(); 50 std::string GetDescription() const override { return std::string(); }
51 } 51 GURL GetURL() const override { return agent_host_->GetURL(); }
52 virtual std::string GetDescription() const override { return std::string(); } 52 GURL GetFaviconURL() const override { return favicon_url_; }
53 virtual GURL GetURL() const override { 53 base::TimeTicks GetLastActivityTime() const override {
54 return agent_host_->GetURL();
55 }
56 virtual GURL GetFaviconURL() const override { return favicon_url_; }
57 virtual base::TimeTicks GetLastActivityTime() const override {
58 return last_activity_time_; 54 return last_activity_time_;
59 } 55 }
60 virtual bool IsAttached() const override { 56 bool IsAttached() const override { return agent_host_->IsAttached(); }
61 return agent_host_->IsAttached(); 57 scoped_refptr<content::DevToolsAgentHost> GetAgentHost() const override {
62 }
63 virtual scoped_refptr<content::DevToolsAgentHost> GetAgentHost()
64 const override {
65 return agent_host_; 58 return agent_host_;
66 } 59 }
67 virtual bool Activate() const override { 60 bool Activate() const override { return agent_host_->Activate(); }
68 return agent_host_->Activate(); 61 bool Close() const override { return agent_host_->Close(); }
69 }
70 virtual bool Close() const override {
71 return agent_host_->Close();
72 }
73 62
74 private: 63 private:
75 scoped_refptr<content::DevToolsAgentHost> agent_host_; 64 scoped_refptr<content::DevToolsAgentHost> agent_host_;
76 GURL favicon_url_; 65 GURL favicon_url_;
77 base::TimeTicks last_activity_time_; 66 base::TimeTicks last_activity_time_;
78 67
79 DISALLOW_COPY_AND_ASSIGN(Target); 68 DISALLOW_COPY_AND_ASSIGN(Target);
80 }; 69 };
81 70
82 Target::Target(scoped_refptr<content::DevToolsAgentHost> agent_host) 71 Target::Target(scoped_refptr<content::DevToolsAgentHost> agent_host)
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 content::DevToolsAgentHost::GetOrCreateAll(); 141 content::DevToolsAgentHost::GetOrCreateAll();
153 for (content::DevToolsAgentHost::List::iterator it = agents.begin(); 142 for (content::DevToolsAgentHost::List::iterator it = agents.begin();
154 it != agents.end(); ++it) { 143 it != agents.end(); ++it) {
155 targets.push_back(new Target(*it)); 144 targets.push_back(new Target(*it));
156 } 145 }
157 callback.Run(targets); 146 callback.Run(targets);
158 } 147 }
159 148
160 } // namespace shell 149 } // namespace shell
161 } // namespace chromecast 150 } // namespace chromecast
OLDNEW
« no previous file with comments | « chromecast/browser/devtools/cast_dev_tools_delegate.h ('k') | chromecast/browser/devtools/remote_debugging_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698