chromecast/media/cma/base/buffering_frame_provider.h - Issue 837453003: Chromecast: virtual/override cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/cma/base/buffering_frame_provider.h

Issue 837453003: Chromecast: virtual/override cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed a few spots Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/media/cma/base/buffering_frame_provider.h

diff --git a/chromecast/media/cma/base/buffering_frame_provider.h b/chromecast/media/cma/base/buffering_frame_provider.h

index 0397676bca016b69772f1f86ffba9502fbf0686f..0cb99e2c59192de8e4c35e8155197e5ab3af24f3 100644

--- a/chromecast/media/cma/base/buffering_frame_provider.h

+++ b/chromecast/media/cma/base/buffering_frame_provider.h

@@ -40,11 +40,11 @@ class BufferingFrameProvider : public CodedFrameProvider {

size_t max_buffer_size,

size_t max_frame_size,

const FrameBufferedCB& frame_buffered_cb);

- virtual ~BufferingFrameProvider();

+ ~BufferingFrameProvider() override;

// CodedFrameProvider implementation.

- virtual void Read(const ReadCB& read_cb) override;

- virtual void Flush(const base::Closure& flush_cb) override;

+ void Read(const ReadCB& read_cb) override;

+ void Flush(const base::Closure& flush_cb) override;

private:

class BufferWithConfig {