Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chromecast/browser/devtools/cast_dev_tools_delegate.cc

Issue 837453003: Chromecast: virtual/override cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: missed a few spots Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/devtools/cast_dev_tools_delegate.cc
diff --git a/chromecast/browser/devtools/cast_dev_tools_delegate.cc b/chromecast/browser/devtools/cast_dev_tools_delegate.cc
index 3041526fba5cf1acd72aeb4b657768d9e86fc3c6..6f28fafdae5ec149c2058b8439f24cf6af212be3 100644
--- a/chromecast/browser/devtools/cast_dev_tools_delegate.cc
+++ b/chromecast/browser/devtools/cast_dev_tools_delegate.cc
@@ -31,9 +31,9 @@ class Target : public content::DevToolsTarget {
public:
explicit Target(scoped_refptr<content::DevToolsAgentHost> agent_host);
- virtual std::string GetId() const override { return agent_host_->GetId(); }
- virtual std::string GetParentId() const override { return std::string(); }
- virtual std::string GetType() const override {
+ std::string GetId() const override { return agent_host_->GetId(); }
+ std::string GetParentId() const override { return std::string(); }
+ std::string GetType() const override {
switch (agent_host_->GetType()) {
case content::DevToolsAgentHost::TYPE_WEB_CONTENTS:
return kTargetTypePage;
@@ -46,30 +46,19 @@ class Target : public content::DevToolsTarget {
}
return kTargetTypeOther;
}
- virtual std::string GetTitle() const override {
- return agent_host_->GetTitle();
- }
- virtual std::string GetDescription() const override { return std::string(); }
- virtual GURL GetURL() const override {
- return agent_host_->GetURL();
- }
- virtual GURL GetFaviconURL() const override { return favicon_url_; }
- virtual base::TimeTicks GetLastActivityTime() const override {
+ std::string GetTitle() const override { return agent_host_->GetTitle(); }
+ std::string GetDescription() const override { return std::string(); }
+ GURL GetURL() const override { return agent_host_->GetURL(); }
+ GURL GetFaviconURL() const override { return favicon_url_; }
+ base::TimeTicks GetLastActivityTime() const override {
return last_activity_time_;
}
- virtual bool IsAttached() const override {
- return agent_host_->IsAttached();
- }
- virtual scoped_refptr<content::DevToolsAgentHost> GetAgentHost()
- const override {
+ bool IsAttached() const override { return agent_host_->IsAttached(); }
+ scoped_refptr<content::DevToolsAgentHost> GetAgentHost() const override {
return agent_host_;
}
- virtual bool Activate() const override {
- return agent_host_->Activate();
- }
- virtual bool Close() const override {
- return agent_host_->Close();
- }
+ bool Activate() const override { return agent_host_->Activate(); }
+ bool Close() const override { return agent_host_->Close(); }
private:
scoped_refptr<content::DevToolsAgentHost> agent_host_;
« no previous file with comments | « chromecast/browser/devtools/cast_dev_tools_delegate.h ('k') | chromecast/browser/devtools/remote_debugging_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698