Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: chromecast/base/metrics/cast_metrics_test_helper.cc

Issue 837453003: Chromecast: virtual/override cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: missed a few spots Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/app/cast_main_delegate.h ('k') | chromecast/browser/cast_browser_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/base/metrics/cast_metrics_test_helper.cc
diff --git a/chromecast/base/metrics/cast_metrics_test_helper.cc b/chromecast/base/metrics/cast_metrics_test_helper.cc
index 6aa2a86a6c84c9180b80321ba2040a3ebabc10c6..f3157e268b97e658bf7d5708d514486c7fd88312 100644
--- a/chromecast/base/metrics/cast_metrics_test_helper.cc
+++ b/chromecast/base/metrics/cast_metrics_test_helper.cc
@@ -16,21 +16,21 @@ namespace {
class CastMetricsHelperStub : public CastMetricsHelper {
public:
CastMetricsHelperStub();
- virtual ~CastMetricsHelperStub();
-
- virtual void TagAppStart(const std::string& arg_app_name) override;
- virtual void LogMediaPlay() override;
- virtual void LogMediaPause() override;
- virtual void LogTimeToDisplayVideo() override;
- virtual void LogTimeToBufferAv(BufferingType buffering_type,
- base::TimeDelta time) override;
- virtual void ResetVideoFrameSampling() override;
- virtual void LogFramesPer5Seconds(
+ ~CastMetricsHelperStub() override;
+
+ void TagAppStart(const std::string& arg_app_name) override;
+ void LogMediaPlay() override;
+ void LogMediaPause() override;
+ void LogTimeToDisplayVideo() override;
+ void LogTimeToBufferAv(BufferingType buffering_type,
+ base::TimeDelta time) override;
+ void ResetVideoFrameSampling() override;
+ void LogFramesPer5Seconds(
int displayed_frames, int dropped_frames,
int delayed_frames, int error_frames) override;
- virtual std::string GetMetricsNameWithAppName(
+ std::string GetMetricsNameWithAppName(
const std::string& prefix, const std::string& suffix) const override;
- virtual void SetMetricsSink(MetricsSink* delegate) override;
+ void SetMetricsSink(MetricsSink* delegate) override;
private:
DISALLOW_COPY_AND_ASSIGN(CastMetricsHelperStub);
« no previous file with comments | « chromecast/app/cast_main_delegate.h ('k') | chromecast/browser/cast_browser_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698