Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 827373003: Drop redundant null checks in SVGListPropertyTearOffHelper (Closed)

Created:
5 years, 11 months ago by Jens Widell
Modified:
5 years, 11 months ago
Reviewers:
fs
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Drop redundant null checks in SVGListPropertyTearOffHelper All interfaces that use this code has [TypeChecking=Interface] so the generated code will do type checking and throw exceptions on invalid arguments. The error handling code removed here could thus never trigger. This patch depends on these fixes for indexed setter type checking: https://codereview.chromium.org/862403002/ https://codereview.chromium.org/871443002/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188821

Patch Set 1 #

Patch Set 2 : add some tests #

Patch Set 3 : fix tests and expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -16 lines) Patch
M LayoutTests/svg/dom/SVGLengthList-basics.xhtml View 1 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/svg/dom/SVGLengthList-basics-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/svg/dom/SVGNumberList-basics.xhtml View 1 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/svg/dom/SVGNumberList-basics-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/svg/dom/SVGPointList-basics.xhtml View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/svg/dom/SVGPointList-basics-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/svg/dom/SVGTransformList-basics.xhtml View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/svg/dom/SVGTransformList-basics-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/svg/properties/SVGListPropertyTearOffHelper.h View 4 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jens Widell
PTAL
5 years, 11 months ago (2015-01-22 15:22:31 UTC) #3
Jens Widell
PTAL
5 years, 11 months ago (2015-01-22 15:22:31 UTC) #4
fs
lgtm
5 years, 11 months ago (2015-01-22 15:39:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827373003/40001
5 years, 11 months ago (2015-01-22 15:40:41 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 17:07:03 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188821

Powered by Google App Engine
This is Rietveld 408576698