LayoutTests/svg/dom/SVGLengthList-basics.xhtml - Issue 827373003: Drop redundant null checks in SVGListPropertyTearOffHelper

Side by Side Diff: LayoutTests/svg/dom/SVGLengthList-basics.xhtml

Issue 827373003: Drop redundant null checks in SVGListPropertyTearOffHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix tests and expectations Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html xmlns="http://www.w3.org/1999/xhtml">	1 <html xmlns="http://www.w3.org/1999/xhtml">

2 <head>	2 <head>

3 <script>window.enablePixelTesting = true;</script>	3 <script>window.enablePixelTesting = true;</script>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="200" height="200">	7 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="200" height="200">

8 <text id="text1" x="500 1000 1500" y="50"> ABC </text>	8 <text id="text1" x="500 1000 1500" y="50"> ABC </text>

9 </svg>	9 </svg>

10	10

(...skipping 98 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
109 debug("Test uncommon arguments for replaceItem()");	109 debug("Test uncommon arguments for replaceItem()");

110 shouldThrow("text1.x.baseVal.replaceItem(30)");	110 shouldThrow("text1.x.baseVal.replaceItem(30)");

111 shouldThrow("text1.x.baseVal.replaceItem('aString')");	111 shouldThrow("text1.x.baseVal.replaceItem('aString')");

112 shouldThrow("text1.x.baseVal.replaceItem(text1)");	112 shouldThrow("text1.x.baseVal.replaceItem(text1)");

113 shouldThrow("text1.x.baseVal.replaceItem(null)");	113 shouldThrow("text1.x.baseVal.replaceItem(null)");

114 shouldThrow("text1.x.baseVal.replaceItem(30, 0)");	114 shouldThrow("text1.x.baseVal.replaceItem(30, 0)");

115 shouldThrow("text1.x.baseVal.replaceItem('aString', 0)");	115 shouldThrow("text1.x.baseVal.replaceItem('aString', 0)");

116 shouldThrow("text1.x.baseVal.replaceItem(text1, 0)");	116 shouldThrow("text1.x.baseVal.replaceItem(text1, 0)");

117 shouldThrow("text1.x.baseVal.replaceItem(null, 0)");	117 shouldThrow("text1.x.baseVal.replaceItem(null, 0)");

118	118

	119 debug("");

	120 debug("Test uncommon values for indexed setter");

	121 shouldThrow("text1.x.baseVal[0] = 30");

	122 shouldThrow("text1.x.baseVal[0] = 'aString'");

	123 shouldThrow("text1.x.baseVal[0] = text1");

	124 shouldThrow("text1.x.baseVal[0] = null");

	125

119 shouldBe("text1.x.baseVal.replaceItem(text1.x.baseVal.getItem(0), 0)", "text 1.x.baseVal.getItem(0)");	126 shouldBe("text1.x.baseVal.replaceItem(text1.x.baseVal.getItem(0), 0)", "text 1.x.baseVal.getItem(0)");

120 shouldBe("text1.x.baseVal.numberOfItems", "4");	127 shouldBe("text1.x.baseVal.numberOfItems", "4");

121 shouldBe("text1.x.baseVal.getItem(0).value", "1");	128 shouldBe("text1.x.baseVal.getItem(0).value", "1");

122 shouldBe("text1.x.baseVal.getItem(1).value", "2");	129 shouldBe("text1.x.baseVal.getItem(1).value", "2");

123 shouldBe("text1.x.baseVal.getItem(2).value", "3");	130 shouldBe("text1.x.baseVal.getItem(2).value", "3");

124 shouldBe("text1.x.baseVal.getItem(3).value", "4");	131 shouldBe("text1.x.baseVal.getItem(3).value", "4");

125 shouldBeEqualToString("text1.getAttribute('x')", "1 2 3 4");	132 shouldBeEqualToString("text1.getAttribute('x')", "1 2 3 4");

126	133

127 shouldBe("text1.x.baseVal.replaceItem(text1.x.baseVal.getItem(0), 'aString') ", "text1.x.baseVal.getItem(0)");	134 shouldBe("text1.x.baseVal.replaceItem(text1.x.baseVal.getItem(0), 'aString') ", "text1.x.baseVal.getItem(0)");

128 shouldBe("text1.x.baseVal.numberOfItems", "4");	135 shouldBe("text1.x.baseVal.numberOfItems", "4");

(...skipping 52 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
181 debug("");	188 debug("");

182 debug("Testing animVal clear throws");	189 debug("Testing animVal clear throws");

183 shouldThrow("text1.x.animVal.clear()");	190 shouldThrow("text1.x.animVal.clear()");

184 shouldBeUndefined("text1.x.baseVal.clear()");	191 shouldBeUndefined("text1.x.baseVal.clear()");

185	192

186 gc();	193 gc();

187 ]]>	194 ]]>

188 </script>	195 </script>

189 </body>	196 </body>

190 </html>	197 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/dom/SVGLengthList-basics-expected.txt » ('j') | no next file with comments »