Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 871443002: IDL: Further improve indexed/named property setter type checking (Closed)

Created:
5 years, 11 months ago by Jens Widell
Modified:
5 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Further improve indexed/named property setter type checking Fix the type check for indexed property setters to only accept null and undefined if the setter's argument is declared nullable. The argument to a setter should behave the same as a method argument. Also change the type check to be slightly more efficient by checking if the value returned by toImplWithTypeCheck() is null rather than calling hasInstance() separately, which is known to be somewhat costly. Also support [TypeChecking=Interface] in the generated code for named property setters. Previously, no type check was generated even if the setter was declared to have one. (This affects no current setters.) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -15 lines) Patch
M Source/bindings/scripts/v8_interface.py View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 2 chunks +10 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/core/TestInterface2.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 4 chunks +30 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
Found some additional issues. PTAL.
5 years, 11 months ago (2015-01-22 12:33:50 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-22 13:40:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871443002/1
5 years, 11 months ago (2015-01-22 13:42:16 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 13:45:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188813

Powered by Google App Engine
This is Rietveld 408576698