Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/svg/dom/SVGTransformList-basics.xhtml

Issue 827373003: Drop redundant null checks in SVGListPropertyTearOffHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix tests and expectations Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/svg/dom/SVGPointList-basics-expected.txt ('k') | LayoutTests/svg/dom/SVGTransformList-basics-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html xmlns="http://www.w3.org/1999/xhtml"> 1 <html xmlns="http://www.w3.org/1999/xhtml">
2 <head> 2 <head>
3 <script>window.enablePixelTesting = true;</script> 3 <script>window.enablePixelTesting = true;</script>
4 <script src="../../resources/js-test.js"></script> 4 <script src="../../resources/js-test.js"></script>
5 </head> 5 </head>
6 <body> 6 <body>
7 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="200" height="200"> 7 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="200" height="200">
8 <circle id="circle1" cx="40" cy="40" r="40" fill="green" transform="scale(2, 2) translate(10 10)"/> 8 <circle id="circle1" cx="40" cy="40" r="40" fill="green" transform="scale(2, 2) translate(10 10)"/>
9 </svg> 9 </svg>
10 10
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 debug("Test uncommon arguments for replaceItem()"); 116 debug("Test uncommon arguments for replaceItem()");
117 shouldThrow("circle1.transform.baseVal.replaceItem(30)"); 117 shouldThrow("circle1.transform.baseVal.replaceItem(30)");
118 shouldThrow("circle1.transform.baseVal.replaceItem('aString')"); 118 shouldThrow("circle1.transform.baseVal.replaceItem('aString')");
119 shouldThrow("circle1.transform.baseVal.replaceItem(circle1)"); 119 shouldThrow("circle1.transform.baseVal.replaceItem(circle1)");
120 shouldThrow("circle1.transform.baseVal.replaceItem(null)"); 120 shouldThrow("circle1.transform.baseVal.replaceItem(null)");
121 shouldThrow("circle1.transform.baseVal.replaceItem(30, 0)"); 121 shouldThrow("circle1.transform.baseVal.replaceItem(30, 0)");
122 shouldThrow("circle1.transform.baseVal.replaceItem('aString', 0)"); 122 shouldThrow("circle1.transform.baseVal.replaceItem('aString', 0)");
123 shouldThrow("circle1.transform.baseVal.replaceItem(circle1, 0)"); 123 shouldThrow("circle1.transform.baseVal.replaceItem(circle1, 0)");
124 shouldThrow("circle1.transform.baseVal.replaceItem(null, 0)"); 124 shouldThrow("circle1.transform.baseVal.replaceItem(null, 0)");
125 125
126 debug("");
127 debug("Test uncommon values for indexed setter");
128 shouldThrow("circle1.transform.baseVal[0] = 30");
129 shouldThrow("circle1.transform.baseVal[0] = 'aString'");
130 shouldThrow("circle1.transform.baseVal[0] = circle1");
131 shouldThrow("circle1.transform.baseVal[0] = null");
132
126 shouldBe("circle1.transform.baseVal.replaceItem(circle1.transform.baseVal.ge tItem(0), 0)", "circle1.transform.baseVal.getItem(0)"); 133 shouldBe("circle1.transform.baseVal.replaceItem(circle1.transform.baseVal.ge tItem(0), 0)", "circle1.transform.baseVal.getItem(0)");
127 shouldBe("circle1.transform.baseVal.numberOfItems", "4"); 134 shouldBe("circle1.transform.baseVal.numberOfItems", "4");
128 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_ROTATE matrix=[0.0 1.0 -1.0 0.0 0.0 0.0]"); 135 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_ROTATE matrix=[0.0 1.0 -1.0 0.0 0.0 0.0]");
129 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(1))", "type=SVG_TRANSFORM_SCALE matrix=[2.0 0.0 0.0 2.0 0.0 0.0]"); 136 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(1))", "type=SVG_TRANSFORM_SCALE matrix=[2.0 0.0 0.0 2.0 0.0 0.0]");
130 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(2))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 10.0 10.0]"); 137 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(2))", "type=SVG_TRANSFORM_TRANSLATE matrix=[1.0 0.0 0.0 1.0 10.0 10.0]");
131 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(3))", "type=SVG_TRANSFORM_SKEWX matrix=[1.0 0.0 1.0 1.0 0.0 0.0]"); 138 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(3))", "type=SVG_TRANSFORM_SKEWX matrix=[1.0 0.0 1.0 1.0 0.0 0.0]");
132 shouldBeEqualToString("circle1.getAttribute('transform')", "rotate(90) scale (2 2) translate(10 10) skewX(45)"); 139 shouldBeEqualToString("circle1.getAttribute('transform')", "rotate(90) scale (2 2) translate(10 10) skewX(45)");
133 140
134 shouldBe("circle1.transform.baseVal.replaceItem(circle1.transform.baseVal.ge tItem(0), 'aString')", "circle1.transform.baseVal.getItem(0)"); 141 shouldBe("circle1.transform.baseVal.replaceItem(circle1.transform.baseVal.ge tItem(0), 'aString')", "circle1.transform.baseVal.getItem(0)");
135 shouldBe("circle1.transform.baseVal.numberOfItems", "4"); 142 shouldBe("circle1.transform.baseVal.numberOfItems", "4");
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 204
198 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.appendItem(tr ansform))", "type=SVG_TRANSFORM_ROTATE matrix=[0.7 0.7 -0.7 0.7 85.4 -6.1]"); 205 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.appendItem(tr ansform))", "type=SVG_TRANSFORM_ROTATE matrix=[0.7 0.7 -0.7 0.7 85.4 -6.1]");
199 shouldBe("circle1.transform.baseVal.numberOfItems", "1"); 206 shouldBe("circle1.transform.baseVal.numberOfItems", "1");
200 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_ROTATE matrix=[0.7 0.7 -0.7 0.7 85.4 -6.1]"); 207 shouldBeEqualToString("dumpTransform(circle1.transform.baseVal.getItem(0))", "type=SVG_TRANSFORM_ROTATE matrix=[0.7 0.7 -0.7 0.7 85.4 -6.1]");
201 shouldBeEqualToString("circle1.getAttribute('transform')", "rotate(45 50 100 )"); 208 shouldBeEqualToString("circle1.getAttribute('transform')", "rotate(45 50 100 )");
202 209
203 ]]> 210 ]]>
204 </script> 211 </script>
205 </body> 212 </body>
206 </html> 213 </html>
OLDNEW
« no previous file with comments | « LayoutTests/svg/dom/SVGPointList-basics-expected.txt ('k') | LayoutTests/svg/dom/SVGTransformList-basics-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698