LayoutTests/svg/dom/SVGNumberList-basics.xhtml - Issue 827373003: Drop redundant null checks in SVGListPropertyTearOffHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/dom/SVGNumberList-basics.xhtml

Issue 827373003: Drop redundant null checks in SVGListPropertyTearOffHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix tests and expectations Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/dom/SVGLengthList-basics-expected.txt ('k') | LayoutTests/svg/dom/SVGNumberList-basics-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/svg/dom/SVGNumberList-basics.xhtml

diff --git a/LayoutTests/svg/dom/SVGNumberList-basics.xhtml b/LayoutTests/svg/dom/SVGNumberList-basics.xhtml

index 11638427fedba85f13b8f448581b62a9575e3207..f8bcd5b25636341424ee806b2c3551d8d16d88d4 100644

--- a/LayoutTests/svg/dom/SVGNumberList-basics.xhtml

+++ b/LayoutTests/svg/dom/SVGNumberList-basics.xhtml

@@ -100,6 +100,13 @@

shouldThrow("text1.rotate.baseVal.replaceItem(text1, 0)");

shouldThrow("text1.rotate.baseVal.replaceItem(null, 0)");

+ debug("");

+ debug("Test uncommon values for indexed setter");

+ shouldThrow("text1.rotate.baseVal[0] = 30");

+ shouldThrow("text1.rotate.baseVal[0] = 'aString'");

+ shouldThrow("text1.rotate.baseVal[0] = text1");

+ shouldThrow("text1.rotate.baseVal[0] = null");

shouldBe("text1.rotate.baseVal.replaceItem(text1.rotate.baseVal.getItem(0), 0)", "text1.rotate.baseVal.getItem(0)");

shouldBe("text1.rotate.baseVal.numberOfItems", "4");

shouldBe("text1.rotate.baseVal.getItem(0).value", "1");

« no previous file with comments | « LayoutTests/svg/dom/SVGLengthList-basics-expected.txt ('k') | LayoutTests/svg/dom/SVGNumberList-basics-expected.txt » ('j') | no next file with comments »