Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/svg/dom/SVGNumberList-basics.xhtml

Issue 827373003: Drop redundant null checks in SVGListPropertyTearOffHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix tests and expectations Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/svg/dom/SVGLengthList-basics-expected.txt ('k') | LayoutTests/svg/dom/SVGNumberList-basics-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html xmlns="http://www.w3.org/1999/xhtml"> 1 <html xmlns="http://www.w3.org/1999/xhtml">
2 <head> 2 <head>
3 <script>window.enablePixelTesting = true;</script> 3 <script>window.enablePixelTesting = true;</script>
4 <script src="../../resources/js-test.js"></script> 4 <script src="../../resources/js-test.js"></script>
5 </head> 5 </head>
6 <body> 6 <body>
7 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="200" height="200"> 7 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="200" height="200">
8 <text id="text1" x="50" y="50" rotate="90 180 270">ABC</text> 8 <text id="text1" x="50" y="50" rotate="90 180 270">ABC</text>
9 </svg> 9 </svg>
10 10
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 debug("Test uncommon arguments for replaceItem()"); 93 debug("Test uncommon arguments for replaceItem()");
94 shouldThrow("text1.rotate.baseVal.replaceItem(30)"); 94 shouldThrow("text1.rotate.baseVal.replaceItem(30)");
95 shouldThrow("text1.rotate.baseVal.replaceItem('aString')"); 95 shouldThrow("text1.rotate.baseVal.replaceItem('aString')");
96 shouldThrow("text1.rotate.baseVal.replaceItem(text1)"); 96 shouldThrow("text1.rotate.baseVal.replaceItem(text1)");
97 shouldThrow("text1.rotate.baseVal.replaceItem(null)"); 97 shouldThrow("text1.rotate.baseVal.replaceItem(null)");
98 shouldThrow("text1.rotate.baseVal.replaceItem(30, 0)"); 98 shouldThrow("text1.rotate.baseVal.replaceItem(30, 0)");
99 shouldThrow("text1.rotate.baseVal.replaceItem('aString', 0)"); 99 shouldThrow("text1.rotate.baseVal.replaceItem('aString', 0)");
100 shouldThrow("text1.rotate.baseVal.replaceItem(text1, 0)"); 100 shouldThrow("text1.rotate.baseVal.replaceItem(text1, 0)");
101 shouldThrow("text1.rotate.baseVal.replaceItem(null, 0)"); 101 shouldThrow("text1.rotate.baseVal.replaceItem(null, 0)");
102 102
103 debug("");
104 debug("Test uncommon values for indexed setter");
105 shouldThrow("text1.rotate.baseVal[0] = 30");
106 shouldThrow("text1.rotate.baseVal[0] = 'aString'");
107 shouldThrow("text1.rotate.baseVal[0] = text1");
108 shouldThrow("text1.rotate.baseVal[0] = null");
109
103 shouldBe("text1.rotate.baseVal.replaceItem(text1.rotate.baseVal.getItem(0), 0)", "text1.rotate.baseVal.getItem(0)"); 110 shouldBe("text1.rotate.baseVal.replaceItem(text1.rotate.baseVal.getItem(0), 0)", "text1.rotate.baseVal.getItem(0)");
104 shouldBe("text1.rotate.baseVal.numberOfItems", "4"); 111 shouldBe("text1.rotate.baseVal.numberOfItems", "4");
105 shouldBe("text1.rotate.baseVal.getItem(0).value", "1"); 112 shouldBe("text1.rotate.baseVal.getItem(0).value", "1");
106 shouldBe("text1.rotate.baseVal.getItem(1).value", "2"); 113 shouldBe("text1.rotate.baseVal.getItem(1).value", "2");
107 shouldBe("text1.rotate.baseVal.getItem(2).value", "3"); 114 shouldBe("text1.rotate.baseVal.getItem(2).value", "3");
108 shouldBe("text1.rotate.baseVal.getItem(3).value", "4"); 115 shouldBe("text1.rotate.baseVal.getItem(3).value", "4");
109 shouldBeEqualToString("text1.getAttribute('rotate')", "1 2 3 4"); 116 shouldBeEqualToString("text1.getAttribute('rotate')", "1 2 3 4");
110 117
111 shouldBe("text1.rotate.baseVal.replaceItem(text1.rotate.baseVal.getItem(0), 'aString')", "text1.rotate.baseVal.getItem(0)"); 118 shouldBe("text1.rotate.baseVal.replaceItem(text1.rotate.baseVal.getItem(0), 'aString')", "text1.rotate.baseVal.getItem(0)");
112 shouldBe("text1.rotate.baseVal.numberOfItems", "4"); 119 shouldBe("text1.rotate.baseVal.numberOfItems", "4");
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 166
160 debug(""); 167 debug("");
161 debug("Testing animVal clear throws"); 168 debug("Testing animVal clear throws");
162 shouldThrow("text1.rotate.animVal.clear()"); 169 shouldThrow("text1.rotate.animVal.clear()");
163 shouldBeUndefined("text1.rotate.baseVal.clear()"); 170 shouldBeUndefined("text1.rotate.baseVal.clear()");
164 171
165 ]]> 172 ]]>
166 </script> 173 </script>
167 </body> 174 </body>
168 </html> 175 </html>
OLDNEW
« no previous file with comments | « LayoutTests/svg/dom/SVGLengthList-basics-expected.txt ('k') | LayoutTests/svg/dom/SVGNumberList-basics-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698