LayoutTests/svg/dom/SVGPointList-basics.xhtml - Issue 827373003: Drop redundant null checks in SVGListPropertyTearOffHelper

Side by Side Diff: LayoutTests/svg/dom/SVGPointList-basics.xhtml

Issue 827373003: Drop redundant null checks in SVGListPropertyTearOffHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix tests and expectations Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/svg/dom/SVGNumberList-basics-expected.txt ('k') | LayoutTests/svg/dom/SVGPointList-basics-expected.txt » ('j') | no next file with comments »

OLD	NEW
1 <html xmlns="http://www.w3.org/1999/xhtml">	1 <html xmlns="http://www.w3.org/1999/xhtml">

2 <head>	2 <head>

3 <script>window.enablePixelTesting = true;</script>	3 <script>window.enablePixelTesting = true;</script>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="200" height="200">	7 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="200" height="200">

8 <polyline id="poly1" stroke="green" points="0 0 100 0 100 100 0 100"/>	8 <polyline id="poly1" stroke="green" points="0 0 100 0 100 100 0 100"/>

9 </svg>	9 </svg>

10	10

(...skipping 105 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
116 debug("Test uncommon arguments for replaceItem()");	116 debug("Test uncommon arguments for replaceItem()");

117 shouldThrow("poly1.points.replaceItem(30)");	117 shouldThrow("poly1.points.replaceItem(30)");

118 shouldThrow("poly1.points.replaceItem('aString')");	118 shouldThrow("poly1.points.replaceItem('aString')");

119 shouldThrow("poly1.points.replaceItem(poly1)");	119 shouldThrow("poly1.points.replaceItem(poly1)");

120 shouldThrow("poly1.points.replaceItem(null, 0)");	120 shouldThrow("poly1.points.replaceItem(null, 0)");

121 shouldThrow("poly1.points.replaceItem('aString', 0)");	121 shouldThrow("poly1.points.replaceItem('aString', 0)");

122 shouldThrow("poly1.points.replaceItem(poly1, 0)");	122 shouldThrow("poly1.points.replaceItem(poly1, 0)");

123 shouldThrow("poly1.points.replaceItem(1, 0)");	123 shouldThrow("poly1.points.replaceItem(1, 0)");

124	124

125 debug("");	125 debug("");

	126 debug("Test uncommon values for indexed setter");

	127 shouldThrow("poly1.points[0] = 30");

	128 shouldThrow("poly1.points[0] = 'aString'");

	129 shouldThrow("poly1.points[0] = poly1");

	130 shouldThrow("poly1.points[0] = null");

	131

	132 debug("");

126 debug("Test uncommon arguments for replaceItem() and xml-dom synchronization ");	133 debug("Test uncommon arguments for replaceItem() and xml-dom synchronization ");

127 shouldBe("poly1.points.numberOfItems", "4");	134 shouldBe("poly1.points.numberOfItems", "4");

128 shouldBeEqualToString("dumpPoint(poly1.points.getItem(0))", "x=0 y=0");	135 shouldBeEqualToString("dumpPoint(poly1.points.getItem(0))", "x=0 y=0");

129 shouldBeEqualToString("dumpPoint(poly1.points.getItem(1))", "x=100 y=0");	136 shouldBeEqualToString("dumpPoint(poly1.points.getItem(1))", "x=100 y=0");

130 shouldBeEqualToString("dumpPoint(poly1.points.getItem(2))", "x=100 y=100");	137 shouldBeEqualToString("dumpPoint(poly1.points.getItem(2))", "x=100 y=100");

131 shouldBeEqualToString("dumpPoint(poly1.points.getItem(3))", "x=0 y=100");	138 shouldBeEqualToString("dumpPoint(poly1.points.getItem(3))", "x=0 y=100");

132 shouldBeEqualToString("poly1.getAttribute('points').formatPointsAttribute()" , "0 0 100 0 100 100 0 100");	139 shouldBeEqualToString("poly1.getAttribute('points').formatPointsAttribute()" , "0 0 100 0 100 100 0 100");

133	140

134 shouldBeEqualToString("dumpPoint(poly1.points.replaceItem(poly1.points.getIt em(0), 0))", "x=0 y=0");	141 shouldBeEqualToString("dumpPoint(poly1.points.replaceItem(poly1.points.getIt em(0), 0))", "x=0 y=0");

135 shouldBe("poly1.points.numberOfItems", "4");	142 shouldBe("poly1.points.numberOfItems", "4");

(...skipping 59 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
195 shouldBeEqualToString("dumpPoint(poly1.points.appendItem(point))", "x=200 y= 100");	202 shouldBeEqualToString("dumpPoint(poly1.points.appendItem(point))", "x=200 y= 100");

196 shouldBe("poly1.points.numberOfItems", "2");	203 shouldBe("poly1.points.numberOfItems", "2");

197 shouldBeEqualToString("dumpPoint(poly1.points.getItem(0))", "x=0 y=100");	204 shouldBeEqualToString("dumpPoint(poly1.points.getItem(0))", "x=0 y=100");

198 shouldBeEqualToString("dumpPoint(poly1.points.getItem(1))", "x=200 y=100");	205 shouldBeEqualToString("dumpPoint(poly1.points.getItem(1))", "x=200 y=100");

199 shouldBeEqualToString("poly1.getAttribute('points').formatPointsAttribute()" , "0 100 200 100");	206 shouldBeEqualToString("poly1.getAttribute('points').formatPointsAttribute()" , "0 100 200 100");

200	207

201 ]]>	208 ]]>

202 </script>	209 </script>

203 </body>	210 </body>

204 </html>	211 </html>

OLD	NEW