Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 824753002: Rename GrGpuGL -> GrGLGpu (Closed)

Created:
6 years ago by jvanverth1
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3251 lines) Patch
M gyp/gpu.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrGpuFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTexture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLBufferImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + src/gpu/gl/GrGLGpu.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/gpu/gl/GrGLGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLIndexBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLRenderTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLStencilBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLTexture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLVertexArray.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLVertexBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/gpu/gl/GrGpuGL.h View 1 chunk +0 lines, -460 lines 0 comments Download
D src/gpu/gl/GrGpuGL.cpp View 1 chunk +0 lines, -2759 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLNvprProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jvanverth1
Whoever wants to take it... it's a lot of files but the change is straightforward.
6 years ago (2014-12-22 18:32:24 UTC) #2
egdaniel
lgtm
6 years ago (2014-12-22 18:39:18 UTC) #3
egdaniel
https://codereview.chromium.org/824753002/diff/1/tests/GLProgramsTest.cpp File tests/GLProgramsTest.cpp (right): https://codereview.chromium.org/824753002/diff/1/tests/GLProgramsTest.cpp#newcode26 tests/GLProgramsTest.cpp:26: #include "gl/GrGLGpu.h" minor nit...alphabetize this above grglpathrendering
6 years ago (2014-12-22 18:40:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824753002/20001
6 years ago (2014-12-22 19:35:05 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-22 19:44:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/39edf7664f50b6c890b933b5bbed67a8735b349b

Powered by Google App Engine
This is Rietveld 408576698