Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 816353008: [Telemetry] Explicitly define Name() method for all perf benchmarks (Closed)

Created:
5 years, 11 months ago by nednguyen
Modified:
5 years, 11 months ago
Reviewers:
sullivan, dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Explicitly define Name() method for all perf benchmarks. To make sure that this does not change any existing benchmarks' names, I added a test in benchmark_unittest. BUG=446891 Committed: https://crrev.com/32006f3b29ab4c5f2a0f43aa9f0d34511c0cfdbb Cr-Commit-Position: refs/heads/master@{#311807}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+571 lines, -9 lines) Patch
M tools/perf/benchmarks/benchmark_unittest.py View 2 chunks +21 lines, -0 lines 1 comment Download
M tools/perf/benchmarks/blink_perf.py View 13 chunks +60 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/dom_perf.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/dromaeo.py View 16 chunks +64 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/image_decoding.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/jetstream.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/kraken.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/maps.py View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/media.py View 6 chunks +24 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/memory.py View 4 chunks +20 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/octane.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/oilpan_gc_times.py View 4 chunks +20 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/page_cycler.py View 12 chunks +60 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/polymer_load.py View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/power.py View 1 chunk +9 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/rasterize_and_record_micro.py View 5 chunks +20 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/repaint.py View 3 chunks +12 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/scheduler.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/service_worker.py View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/session_restore.py View 3 chunks +12 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/skpicture_printer.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/smoothness.py View 13 chunks +72 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/spaceport.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/speedometer.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/start_with_url.py View 3 chunks +12 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/startup.py View 7 chunks +32 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/sunspider.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/tab_switching.py View 4 chunks +20 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/task_execution_time.py View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/thread_times.py View 5 chunks +25 lines, -5 lines 0 comments Download
M tools/perf/benchmarks/v8.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/webrtc.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
nednguyen
5 years, 11 months ago (2015-01-15 15:47:38 UTC) #2
dtu
lgtm https://codereview.chromium.org/816353008/diff/1/tools/perf/benchmarks/benchmark_unittest.py File tools/perf/benchmarks/benchmark_unittest.py (right): https://codereview.chromium.org/816353008/diff/1/tools/perf/benchmarks/benchmark_unittest.py#newcode54 tools/perf/benchmarks/benchmark_unittest.py:54: class TestPerfBenchmarkNames(unittest.TestCase): Do you even want to check ...
5 years, 11 months ago (2015-01-15 21:27:23 UTC) #3
nednguyen
On 2015/01/15 21:27:23, dtu wrote: > lgtm > > https://codereview.chromium.org/816353008/diff/1/tools/perf/benchmarks/benchmark_unittest.py > File tools/perf/benchmarks/benchmark_unittest.py (right): > ...
5 years, 11 months ago (2015-01-15 21:39:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816353008/1
5 years, 11 months ago (2015-01-15 21:41:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/45756)
5 years, 11 months ago (2015-01-15 23:54:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816353008/1
5 years, 11 months ago (2015-01-16 00:43:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 01:21:33 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 01:22:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32006f3b29ab4c5f2a0f43aa9f0d34511c0cfdbb
Cr-Commit-Position: refs/heads/master@{#311807}

Powered by Google App Engine
This is Rietveld 408576698