Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: tools/perf/benchmarks/startup.py

Issue 816353008: [Telemetry] Explicitly define Name() method for all perf benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/startup.py
diff --git a/tools/perf/benchmarks/startup.py b/tools/perf/benchmarks/startup.py
index e89a4e13b1a2f19ede3874ec6d8f48e2874037f9..3fa3e34f5963684d63c37c7c712787abef2ed851 100644
--- a/tools/perf/benchmarks/startup.py
+++ b/tools/perf/benchmarks/startup.py
@@ -11,6 +11,10 @@ class _StartupCold(benchmark.Benchmark):
"""Measures cold startup time with a clean profile."""
options = {'pageset_repeat': 5}
+ @classmethod
+ def Name(cls):
+ return 'startup'
+
def CreatePageTest(self, options):
return startup.Startup(cold=True)
@@ -19,6 +23,10 @@ class _StartupWarm(benchmark.Benchmark):
"""Measures warm startup time with a clean profile."""
options = {'pageset_repeat': 20}
+ @classmethod
+ def Name(cls):
+ return 'startup'
+
def CreatePageTest(self, options):
return startup.Startup(cold=False)
@@ -30,6 +38,10 @@ class StartupColdBlankPage(_StartupCold):
tag = 'cold'
page_set = page_sets.BlankPageSet
+ @classmethod
+ def Name(cls):
+ return 'startup.cold.blank_page'
+
@benchmark.Enabled('has tabs')
class StartupWarmBlankPage(_StartupWarm):
@@ -37,6 +49,10 @@ class StartupWarmBlankPage(_StartupWarm):
tag = 'warm'
page_set = page_sets.BlankPageSet
+ @classmethod
+ def Name(cls):
+ return 'startup.warm.blank_page'
+
@benchmark.Disabled # crbug.com/336913
class StartupColdTheme(_StartupCold):
@@ -44,6 +60,10 @@ class StartupColdTheme(_StartupCold):
page_set = page_sets.BlankPageSet
generated_profile_archive = 'theme_profile.zip'
+ @classmethod
+ def Name(cls):
+ return 'startup.theme_cold.blank_page'
+
@benchmark.Disabled
class StartupWarmTheme(_StartupWarm):
@@ -51,6 +71,10 @@ class StartupWarmTheme(_StartupWarm):
page_set = page_sets.BlankPageSet
generated_profile_archive = 'theme_profile.zip'
+ @classmethod
+ def Name(cls):
+ return 'startup.theme_warm.blank_page'
+
@benchmark.Disabled # crbug.com/336913
class StartupColdManyExtensions(_StartupCold):
@@ -58,9 +82,17 @@ class StartupColdManyExtensions(_StartupCold):
page_set = page_sets.BlankPageSet
generated_profile_archive = 'many_extensions_profile.zip'
+ @classmethod
+ def Name(cls):
+ return 'startup.many_extensions_cold.blank_page'
+
@benchmark.Disabled
class StartupWarmManyExtensions(_StartupWarm):
tag = 'many_extensions_warm'
page_set = page_sets.BlankPageSet
generated_profile_archive = 'many_extensions_profile.zip'
+ @classmethod
+ def Name(cls):
+ return 'startup.many_extensions_warm.blank_page'
+

Powered by Google App Engine
This is Rietveld 408576698