Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: tools/perf/benchmarks/dromaeo.py

Issue 816353008: [Telemetry] Explicitly define Name() method for all perf benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/dromaeo.py
diff --git a/tools/perf/benchmarks/dromaeo.py b/tools/perf/benchmarks/dromaeo.py
index 1f32d3923bdf36175d00c566a28d355b330d048b..2e6f9a942792198e39ed21831294cba77c7a3bf4 100644
--- a/tools/perf/benchmarks/dromaeo.py
+++ b/tools/perf/benchmarks/dromaeo.py
@@ -98,6 +98,10 @@ class _DromaeoBenchmark(benchmark.Benchmark):
"""A base class for Dromaeo benchmarks."""
test = _DromaeoMeasurement
+ @classmethod
+ def Name(cls):
+ return 'dromaeo'
+
def CreatePageSet(self, options):
"""Makes a PageSet for Dromaeo benchmarks."""
# Subclasses are expected to define class members called query_param and
@@ -122,6 +126,10 @@ class DromaeoDomCoreAttr(_DromaeoBenchmark):
tag = 'domcoreattr'
query_param = 'dom-attr'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.domcoreattr'
+
class DromaeoDomCoreModify(_DromaeoBenchmark):
"""Dromaeo DOMCore modify JavaScript benchmark.
@@ -131,6 +139,10 @@ class DromaeoDomCoreModify(_DromaeoBenchmark):
tag = 'domcoremodify'
query_param = 'dom-modify'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.domcoremodify'
+
class DromaeoDomCoreQuery(_DromaeoBenchmark):
"""Dromaeo DOMCore query JavaScript benchmark.
@@ -140,6 +152,10 @@ class DromaeoDomCoreQuery(_DromaeoBenchmark):
tag = 'domcorequery'
query_param = 'dom-query'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.domcorequery'
+
class DromaeoDomCoreTraverse(_DromaeoBenchmark):
"""Dromaeo DOMCore traverse JavaScript benchmark.
@@ -149,6 +165,10 @@ class DromaeoDomCoreTraverse(_DromaeoBenchmark):
tag = 'domcoretraverse'
query_param = 'dom-traverse'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.domcoretraverse'
+
class DromaeoJslibAttrJquery(_DromaeoBenchmark):
"""Dromaeo JSLib attr jquery JavaScript benchmark.
@@ -159,6 +179,10 @@ class DromaeoJslibAttrJquery(_DromaeoBenchmark):
tag = 'jslibattrjquery'
query_param = 'jslib-attr-jquery'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.jslibattrjquery'
+
class DromaeoJslibAttrPrototype(_DromaeoBenchmark):
"""Dromaeo JSLib attr prototype JavaScript benchmark.
@@ -169,6 +193,10 @@ class DromaeoJslibAttrPrototype(_DromaeoBenchmark):
tag = 'jslibattrprototype'
query_param = 'jslib-attr-prototype'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.jslibattrprototype'
+
class DromaeoJslibEventJquery(_DromaeoBenchmark):
"""Dromaeo JSLib event jquery JavaScript benchmark.
@@ -179,6 +207,10 @@ class DromaeoJslibEventJquery(_DromaeoBenchmark):
tag = 'jslibeventjquery'
query_param = 'jslib-event-jquery'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.jslibeventjquery'
+
class DromaeoJslibEventPrototype(_DromaeoBenchmark):
"""Dromaeo JSLib event prototype JavaScript benchmark.
@@ -189,6 +221,10 @@ class DromaeoJslibEventPrototype(_DromaeoBenchmark):
tag = 'jslibeventprototype'
query_param = 'jslib-event-prototype'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.jslibeventprototype'
+
@benchmark.Disabled('xp') # crbug.com/389731
class DromaeoJslibModifyJquery(_DromaeoBenchmark):
@@ -200,6 +236,10 @@ class DromaeoJslibModifyJquery(_DromaeoBenchmark):
tag = 'jslibmodifyjquery'
query_param = 'jslib-modify-jquery'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.jslibmodifyjquery'
+
class DromaeoJslibModifyPrototype(_DromaeoBenchmark):
"""Dromaeo JSLib modify prototype JavaScript benchmark.
@@ -210,6 +250,10 @@ class DromaeoJslibModifyPrototype(_DromaeoBenchmark):
tag = 'jslibmodifyprototype'
query_param = 'jslib-modify-prototype'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.jslibmodifyprototype'
+
class DromaeoJslibStyleJquery(_DromaeoBenchmark):
"""Dromaeo JSLib style jquery JavaScript benchmark.
@@ -220,6 +264,10 @@ class DromaeoJslibStyleJquery(_DromaeoBenchmark):
tag = 'jslibstylejquery'
query_param = 'jslib-style-jquery'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.jslibstylejquery'
+
class DromaeoJslibStylePrototype(_DromaeoBenchmark):
"""Dromaeo JSLib style prototype JavaScript benchmark.
@@ -230,6 +278,10 @@ class DromaeoJslibStylePrototype(_DromaeoBenchmark):
tag = 'jslibstyleprototype'
query_param = 'jslib-style-prototype'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.jslibstyleprototype'
+
class DromaeoJslibTraverseJquery(_DromaeoBenchmark):
"""Dromaeo JSLib traverse jquery JavaScript benchmark.
@@ -241,6 +293,10 @@ class DromaeoJslibTraverseJquery(_DromaeoBenchmark):
tag = 'jslibtraversejquery'
query_param = 'jslib-traverse-jquery'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.jslibtraversejquery'
+
class DromaeoJslibTraversePrototype(_DromaeoBenchmark):
"""Dromaeo JSLib traverse prototype JavaScript benchmark.
@@ -250,6 +306,10 @@ class DromaeoJslibTraversePrototype(_DromaeoBenchmark):
tag = 'jslibtraverseprototype'
query_param = 'jslib-traverse-prototype'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.jslibtraverseprototype'
+
class DromaeoCSSQueryJquery(_DromaeoBenchmark):
"""Dromaeo CSS Query jquery JavaScript benchmark.
@@ -259,3 +319,7 @@ class DromaeoCSSQueryJquery(_DromaeoBenchmark):
tag = 'cssqueryjquery'
query_param = 'cssquery-jquery'
+ @classmethod
+ def Name(cls):
+ return 'dromaeo.cssqueryjquery'
+

Powered by Google App Engine
This is Rietveld 408576698